From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: meson: add libretech-pc boards support
Date: Sun, 8 Dec 2019 19:05:16 +0100 [thread overview]
Message-ID: <CAFBinCDMxf6tJt+bkfN7W5CMJrqZ+F1zTC=q8xmYtxg7gpEJxg@mail.gmail.com> (raw)
In-Reply-To: <20191206100218.480348-5-jbrunet@baylibre.com>
Hi Jerome,
this is looking good overall - I have some questions / nit-picks below
On Fri, Dec 6, 2019 at 11:02 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
[...]
> + adc_keys {
on most boards we use "adc-keys" instead of "adc_keys"
[...]
> + button-onoff {
> + label = "On/Off";
> + linux,code = <KEY_VENDOR>;
based on the label I assumed that the code is KEY_POWER
why is KEY_VENDOR the better choice here?
[...]
> + cvbs-connector {
> + compatible = "composite-video-connector";
> + status = "disabled";
is there CVBS on the board? if I remember correctly the VPU driver
works fine when omitting the CVBS connector
so if the board doesn't have it you may drop the whole node instead of
keeping it disabled
[...]
> + leds {
> + compatible = "gpio-leds";
> +
> + green {
> + label = "librecomputer:green:disk";
you can use the "function" and "color" properties instead of the (now
deprecated) "label"
[...]
> +&external_mdio {
> + external_phy: ethernet-phy@0 {
> + reg = <0>;
it would be great to have a comment above which PHY is used on this board
> + max-speed = <1000>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <30000>;
> + reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>;
> + interrupt-parent = <&gpio_intc>;
a comment like /* MAC_INTR on GPIOZ_15 */ would be great here
> + interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
[...]
> +&pinctrl_periphs {
> + /*
> + * Make sure the reset pin of the usb HUB is driven high to take
> + * it out of reset.
> + */
> + usb1_rst_pins: usb1_rst_irq {
> + mux {
> + groups = "GPIODV_3";
> + function = "gpio_periphs";
> + bias-disable;
> + output-high;
> + };
> + };
on other boards (like Odroid-C2) we use a GPIO hog for this. I'm not
sure which one is better
[...]
> +&pinctrl_periphs {
> + /*
> + * Make sure the irq pin of the TYPE C controller is not driven
> + * by the SoC.
is this because the SoC default configuration pulls the IRQ line LOW,
which then generates "phantom" IRQs?
[...]
> + fusb302@22 {
typec-portc@22
[...]
> + interrupt-parent = <&gpio_intc>;
> + interrupts = <59 IRQ_TYPE_LEVEL_LOW>;
a comment above with the GPIO number would be great
Martin
next prev parent reply other threads:[~2019-12-08 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 10:02 [PATCH 0/4] arm64: dts: meson: add libretech-pc support Jerome Brunet
2019-12-06 10:02 ` [PATCH 1/4] arm64: dts: meson: gxl: add i2c C pins Jerome Brunet
2019-12-06 10:02 ` [PATCH 2/4] arm64: defconfig: enable FUSB302 as module Jerome Brunet
2019-12-06 10:02 ` [PATCH 3/4] dt-bindings: arm: amlogic: add libretech-pc bindings Jerome Brunet
2019-12-06 10:02 ` [PATCH 4/4] arm64: dts: meson: add libretech-pc boards support Jerome Brunet
2019-12-08 18:05 ` Martin Blumenstingl [this message]
2019-12-09 10:15 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCDMxf6tJt+bkfN7W5CMJrqZ+F1zTC=q8xmYtxg7gpEJxg@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).