From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933868AbcCNN5t (ORCPT ); Mon, 14 Mar 2016 09:57:49 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37467 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbcCNN5r (ORCPT ); Mon, 14 Mar 2016 09:57:47 -0400 MIME-Version: 1.0 In-Reply-To: <20160311075151.GA7902@mwanda> References: <20160311075151.GA7902@mwanda> From: Oded Gabbay Date: Mon, 14 Mar 2016 15:57:16 +0200 Message-ID: Subject: Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() To: Dan Carpenter Cc: Yair Shachar , David Airlie , Maling list - DRI developers , "Linux-Kernel@Vger. Kernel. Org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter wrote: > At the end of the function we expect "status" to be zero, but it's > either -EINVAL or unitialized. > > Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c > index c34c393..d5e19b5 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c > @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers( > union SQ_CMD_BITS *in_reg_sq_cmd, > union GRBM_GFX_INDEX_BITS *in_reg_gfx_index) > { > - int status; > + int status = 0; > union SQ_CMD_BITS reg_sq_cmd; > union GRBM_GFX_INDEX_BITS reg_gfx_index; > struct HsaDbgWaveMsgAMDGen2 *pMsg; Thanks, applied to my fixes tree. Oded