From: Oded Gabbay <oded.gabbay@gmail.com>
To: Omer Shpigelman <oshpigelman@habana.ai>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] habanalbas: rephrase error message
Date: Sun, 5 Jul 2020 00:39:04 +0300 [thread overview]
Message-ID: <CAFCwf12WXAnVA1mTCxiifG7npi4hVJquPvC_NTG-9c4Gyc+u1A@mail.gmail.com> (raw)
In-Reply-To: <20200704195116.19669-1-oshpigelman@habana.ai>
On Sat, Jul 4, 2020 at 10:51 PM Omer Shpigelman <oshpigelman@habana.ai> wrote:
>
> Rephrase F/W error message to make it more understandable to ordinary
> users.
>
> Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
> ---
> drivers/misc/habanalabs/firmware_if.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b78..171baa2b56b0 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
> "Device reports FIT image is corrupted\n");
> else
> dev_err(hdev->dev,
> - "Device failed to load, %d\n", status);
> + "Failed to load firmware to device, %d\n",
> + status);
>
> rc = -EIO;
> goto out;
> --
> 2.17.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
prev parent reply other threads:[~2020-07-04 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 19:51 [PATCH] habanalbas: rephrase error message Omer Shpigelman
2020-07-04 21:39 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf12WXAnVA1mTCxiifG7npi4hVJquPvC_NTG-9c4Gyc+u1A@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oshpigelman@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).