linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, SW_Drivers <SW_Drivers@habana.ai>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Omer Shpigelman <oshpigelman@habana.ai>
Subject: Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations
Date: Sat, 12 Sep 2020 18:19:50 +0300	[thread overview]
Message-ID: <CAFCwf12kfQJk5XwcX7qRRC-oLfXAUr+DSdBv0X9RcEDpyxJirA@mail.gmail.com> (raw)
In-Reply-To: <59a861d7-86e5-d806-a195-fd229d27ffb4@infradead.org>

On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 9/12/20 7:41 AM, Oded Gabbay wrote:
> > +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
>
>
> ioctl numbers ('H') should be documented in
> Documentation/userspace-api/ioctl/ioctl-number.rst
>
> Sorry if I missed seeing that. (I scanned quickly.)
>
> thanks.
>
> --
> ~Randy
>

Hi Randy,
It is already documented for some time now:

'H'   00-0F  uapi/misc/habanalabs.h                                  conflict!

I think you commented on this a few releases ago and I added it then :)

Thanks,
Oded

  reply	other threads:[~2020-09-12 15:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 14:40 [PATCH v2 00/14] Adding GAUDI NIC code to habanalabs driver Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 02/14] habanalabs/gaudi: add NIC firmware-related definitions Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 03/14] habanalabs/gaudi: add NIC security configuration Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 04/14] habanalabs/gaudi: add support for NIC QMANs Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 05/14] habanalabs/gaudi: add NIC Ethernet support Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 06/14] habanalabs/gaudi: add NIC PHY code Oded Gabbay
2020-09-12 14:40 ` [PATCH v2 07/14] habanalabs/gaudi: allow user to get MAC addresses in INFO IOCTL Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations Oded Gabbay
2020-09-12 15:07   ` Randy Dunlap
2020-09-12 15:19     ` Oded Gabbay [this message]
2020-09-12 15:23       ` Randy Dunlap
2020-09-12 14:41 ` [PATCH v2 09/14] habanalabs/gaudi: add CQ " Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 10/14] habanalabs/gaudi: add WQ " Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 11/14] habanalabs/gaudi: add QP error handling Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 12/14] habanalabs/gaudi: Add ethtool support using coresight Oded Gabbay
2020-09-14  1:24   ` Andrew Lunn
2020-09-14 20:07     ` Jakub Kicinski
2020-09-14 20:53       ` Oded Gabbay
2020-09-14  1:37   ` Andrew Lunn
2020-09-14  5:15     ` Oded Gabbay
2020-09-14  1:39   ` Florian Fainelli
2020-09-14  5:14     ` Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 13/14] habanalabs/gaudi: support DCB protocol Oded Gabbay
2020-09-12 14:41 ` [PATCH v2 14/14] habanalabs/gaudi: add NIC init/fini calls from common code Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFCwf12kfQJk5XwcX7qRRC-oLfXAUr+DSdBv0X9RcEDpyxJirA@mail.gmail.com \
    --to=oded.gabbay@gmail.com \
    --cc=SW_Drivers@habana.ai \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oshpigelman@habana.ai \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).