From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3F0C433ED for ; Wed, 12 May 2021 20:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4D3F613FB for ; Wed, 12 May 2021 20:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344952AbhELUAh (ORCPT ); Wed, 12 May 2021 16:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245131AbhELSYW (ORCPT ); Wed, 12 May 2021 14:24:22 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7F38C061763 for ; Wed, 12 May 2021 11:21:31 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id h4so35138217lfv.0 for ; Wed, 12 May 2021 11:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dg0aT9CGnTa3wuH7NsxQOFQv42isTf38NzWAad/uPQE=; b=ctV+PfMrQmaJ6slkQjOSQ6FIInzYoAdDelIR0/I7GSCPQ4WH2Q8dxhHwgJMrmZbwGL kh6tCAmEynkqhBqS2Zq535RALK3OuF+bx9QSLY5qSu3hgltGeBxYdo2kf08oONihR7MR hR6/ZCVFamIbKX3nUP3xLRMq0Ew0MuQNkLrDr5/H2rsOtDKcCuBLixVoYhpoXQZTsEl3 SGcq8ehsB83FCjS3drP5fg7FkAKKbXe2nsbpRhVUKeyiBErpIdAdlPPoIQ/dWMzCnecd xHEgkbJmZjX1Y32vvilyiCyPYdhgJ1mBKRj9+8kHUGCzaO3SprhU7wjBjmCZ9hgSUpSy okag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dg0aT9CGnTa3wuH7NsxQOFQv42isTf38NzWAad/uPQE=; b=QMMi7PxR3gxrytNhWnmU/WB6QRUhca5Yxq7y3fvm5rgitrD3entjK45grp3HSL0zUD djnUgi+BS3tlUC157dXYqYE/DEmI+67kj26Ur4XyU/hAtf1LVTs801eOVrQcSozxD//v ndeH7rZiQuBKgT1f/yASChWbVfpkVnma6RYFcLIvKCNYtc7CenwIODU8eXYinV1Tv9/D KyjEK7hM9pLsA48nNoWf0G2kcbIUVJ74YJMfxsgE8+svt1yKQ4vqLAgpzcnsfDXqxDHJ ueGjOv/L3qmKjoVzXzUMbCE5x5BI1TeEkIPhEgl3vYHBxAsA7zMN9oh191aikN4SPc6e su7Q== X-Gm-Message-State: AOAM532sFNmEv3De8v41/Yqy384nwNvwJ9hgYm/F3t7jqhP3YIT1143q tSCDdZxckskrhTaBkdlU4qV3O6DFOqsfnFG1LEKHUQ== X-Google-Smtp-Source: ABdhPJyMQQ57JywNBx+Etccl693u861JrcS1dP7sUHeNMxrNogeWNU6kbdnM9bk0QULlC4xClEAX/ReXS4wVQSi6JgM= X-Received: by 2002:ac2:428e:: with SMTP id m14mr25450552lfh.478.1620843689766; Wed, 12 May 2021 11:21:29 -0700 (PDT) MIME-Version: 1.0 References: <20210414021201.2462114-1-lzye@google.com> In-Reply-To: From: Chris Ye Date: Wed, 12 May 2021 11:21:18 -0700 Message-ID: Subject: Re: [PATCH] [v5] Input: Add "Select" button to Microsoft Xbox One controller. To: =?UTF-8?Q?=C5=81ukasz_Patron?= , Benjamin Valentin , Chris Ye , Lee Jones , =?UTF-8?Q?Olivier_Cr=C3=AAte?= , Sanjay Govind , Andrzej Pietrasiewicz , Bastien Nocera Cc: linux-input , lkml , trivial@kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, It seems I don't have any further comments on patch v5, do you think we can land the patch in the next kernel release? Please advise if there are any further comments. Thank you! Regards, Chris On Wed, May 5, 2021 at 9:57 AM Chris Ye wrote: > > Hi Bastien, > Can you please take a look at the patch v5, which has restored > the same tab formatting? > Thanks! Regards, > Chris > > On Tue, Apr 13, 2021 at 7:12 PM Chris Ye wrote: > > > > Add "Select" button input capability and input event mapping for > > Microsoft Xbox One controller. From product site this is also referred as > > "Share" button. > > Fixed Microsoft Xbox One controller select button not working under USB > > connection. > > > > Signed-off-by: Chris Ye > > --- > > drivers/input/joystick/xpad.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > > index 9f0d07dcbf06..cfbf1747b205 100644 > > --- a/drivers/input/joystick/xpad.c > > +++ b/drivers/input/joystick/xpad.c > > @@ -79,6 +79,7 @@ > > #define MAP_DPAD_TO_BUTTONS (1 << 0) > > #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) > > #define MAP_STICKS_TO_NULL (1 << 2) > > +#define MAP_SELECT_BUTTON (1 << 3) > > #define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS | \ > > MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL) > > > > @@ -130,6 +131,7 @@ static const struct xpad_device { > > { 0x045e, 0x02e3, "Microsoft X-Box One Elite pad", 0, XTYPE_XBOXONE }, > > { 0x045e, 0x02ea, "Microsoft X-Box One S pad", 0, XTYPE_XBOXONE }, > > { 0x045e, 0x0719, "Xbox 360 Wireless Receiver", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360W }, > > + { 0x045e, 0x0b12, "Microsoft Xbox One X pad", MAP_SELECT_BUTTON, XTYPE_XBOXONE }, > > { 0x046d, 0xc21d, "Logitech Gamepad F310", 0, XTYPE_XBOX360 }, > > { 0x046d, 0xc21e, "Logitech Gamepad F510", 0, XTYPE_XBOX360 }, > > { 0x046d, 0xc21f, "Logitech Gamepad F710", 0, XTYPE_XBOX360 }, > > @@ -862,6 +864,8 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char > > /* menu/view buttons */ > > input_report_key(dev, BTN_START, data[4] & 0x04); > > input_report_key(dev, BTN_SELECT, data[4] & 0x08); > > + if (xpad->mapping & MAP_SELECT_BUTTON) > > + input_report_key(dev, KEY_RECORD, data[22] & 0x01); > > > > /* buttons A,B,X,Y */ > > input_report_key(dev, BTN_A, data[4] & 0x10); > > @@ -1672,6 +1676,8 @@ static int xpad_init_input(struct usb_xpad *xpad) > > xpad->xtype == XTYPE_XBOXONE) { > > for (i = 0; xpad360_btn[i] >= 0; i++) > > input_set_capability(input_dev, EV_KEY, xpad360_btn[i]); > > + if (xpad->mapping & MAP_SELECT_BUTTON) > > + input_set_capability(input_dev, EV_KEY, KEY_RECORD); > > } else { > > for (i = 0; xpad_btn[i] >= 0; i++) > > input_set_capability(input_dev, EV_KEY, xpad_btn[i]); > > -- > > 2.31.1.295.g9ea45b61b8-goog > >