From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932074AbcFBD6Y (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jun 2016 23:58:24 -0400
Received: from mail-io0-f177.google.com ([209.85.223.177]:35809 "EHLO
	mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752184AbcFBD6X (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jun 2016 23:58:23 -0400
MIME-Version: 1.0
In-Reply-To: <1464802762-23933-3-git-send-email-john.stultz@linaro.org>
References: <1464802762-23933-1-git-send-email-john.stultz@linaro.org>
	<1464802762-23933-3-git-send-email-john.stultz@linaro.org>
Date: Thu, 2 Jun 2016 11:58:23 +0800
Message-ID: <CAFGCpxwSzenbng9SGyB24u5NfZN8tj5MOQ9zjeUjH_jJpzL5eQ@mail.gmail.com>
Subject: Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support
From: Guodong Xu <guodong.xu@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Wei Xu <xuwei5@hisilicon.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2 June 2016 at 01:39, John Stultz <john.stultz@linaro.org> wrote:
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>
> Add pl031 rtc0 support to hi6220 dtsi
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> [jstultz: Forward ported and tweaked commit description]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 189d215..1288995 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -336,6 +336,14 @@
>                         clock-names = "timer1", "timer2", "apb_pclk";
>                 };
>
> +               rtc0: rtc@170000 {
> +                       compatible = "arm,pl031", "arm,primecell";
> +                       reg = <0x0 0xf8003000 0x0 0x1000>;
> +                       interrupts = <0 12 4>;
> +                       clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
> +                       clock-names = "apb_pclk";
> +               };
> +

Hi, John

Checked from Hi6220 spec, and verified on HiKey:

+               rtc1: rtc@f8004000 {
+                       compatible = "arm,pl031", "arm,primecell";
+                       reg = <0x0 0xf8004000 0x0 0x1000>;
+                       interrupts = <0 8 4>;
+                       clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
+                       clock-names = "apb_pclk";
+               };
+

Would you please append that into the patch?

-Guodong

>                 pmx0: pinmux@f7010000 {
>                         compatible = "pinctrl-single";
>                         reg = <0x0 0xf7010000  0x0 0x27c>;
> --
> 1.9.1
>