From: Guodong Xu <guodong.xu@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Olof Johansson <olof@lixom.net>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Riku Voipio <riku.voipio@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Eric Anholt <eric@anholt.net>,
damm+renesas@opensource.se,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"hw Wang(Xiaoyin)" <hw.wangxiaoyin@hisilicon.com>
Subject: Re: [PATCH 2/6] mfd: hi6421-pmic: move hi6421_regmap_config definition to header file
Date: Sat, 27 May 2017 11:08:29 +0800 [thread overview]
Message-ID: <CAFGCpxxiwevKqJ19v7fFe6SA9HUbDsdoiL3nOKrkRLmg2=U2xw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0maxQdwLMMwEnYgmMHRHDRUaeYRb5JM0PtRbWopeHjUw@mail.gmail.com>
On Fri, May 26, 2017 at 4:33 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, May 26, 2017 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
>> Move hi6421_regmap_config definition from c code to common header:
>> - include/linux/mfd/hi6421-pmic.h
>>
>> This is to improve code re-use for upcoming hi6421 series of MFD driver.
>>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>
>> diff --git a/include/linux/mfd/hi6421-pmic.h b/include/linux/mfd/hi6421-pmic.h
>> index 587273e..f4674ff 100644
>> --- a/include/linux/mfd/hi6421-pmic.h
>> +++ b/include/linux/mfd/hi6421-pmic.h
>> @@ -38,4 +38,10 @@ struct hi6421_pmic {
>> struct regmap *regmap;
>> };
>>
>> +static const struct regmap_config hi6421_regmap_config = {
>> + .reg_bits = 32,
>> + .reg_stride = 4,
>> + .val_bits = 8,
>> + .max_register = HI6421_REG_TO_BUS_ADDR(HI6421_REG_MAX),
>> +};
>> #endif /* __HI6421_PMIC_H */
>
> Header files should not have static variables in general, it will cause warnings
> about unused variables when you include the header from another file
> (depending on compiler version and warning options, I think older gcc
> versions don't warn about this, but clang and latest gcc do).
>
I will fix that.
> How about adding the new code into the existing
> drivers/mfd/hi6421-pmic-core.c file, and splitting out the part that differs
> (the regmap_update_bits is the only difference I see)
Yes, indeed.
> into a callback
> that you reference through the of_device_id->data pointer?
>
Thanks Arnd. I will look into this. I'll drop hi6421v530-pmic.c and
resend this patchset.
-Guodong
> Arnd
next prev parent reply other threads:[~2017-05-27 3:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 6:35 [PATCH 0/6] MFD: add driver for HiSilicon Hi6421v530 PMIC Guodong Xu
2017-05-26 6:35 ` [PATCH 1/6] dt-bindings: mfd: Add hi6421v530 bindings Guodong Xu
2017-05-31 18:07 ` Rob Herring
2017-06-02 9:01 ` Guodong Xu
2017-05-26 6:35 ` [PATCH 2/6] mfd: hi6421-pmic: move hi6421_regmap_config definition to header file Guodong Xu
2017-05-26 8:33 ` Arnd Bergmann
2017-05-27 3:08 ` Guodong Xu [this message]
2017-05-26 6:35 ` [PATCH 3/6] mfd: hi6421v530: add support for HiSilicon Hi6421v530 Guodong Xu
2017-05-30 7:36 ` Lee Jones
2017-06-02 9:35 ` Guodong Xu
2017-05-26 6:35 ` [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530 voltage regulator Guodong Xu
2017-05-26 11:38 ` Mark Brown
2017-05-27 9:47 ` Guodong Xu
2017-05-26 12:13 ` Javier Martinez Canillas
2017-05-27 9:42 ` Guodong Xu
2017-05-26 6:35 ` [PATCH 5/6] arm64: dts: hikey960: add device node for pmic and regulators Guodong Xu
2017-05-26 6:35 ` [PATCH 6/6] arm64: defconfig: enable hi6421v530 MFD and regulator Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFGCpxxiwevKqJ19v7fFe6SA9HUbDsdoiL3nOKrkRLmg2=U2xw@mail.gmail.com' \
--to=guodong.xu@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=damm+renesas@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@free-electrons.com \
--cc=hw.wangxiaoyin@hisilicon.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=riku.voipio@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).