From: Guodong Xu <guodong.xu@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Xu Wei <xuwei5@hisilicon.com>,
Mark Rutland <mark.rutland@arm.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
XinWei Kong <kong.kongxinwei@hisilicon.com>,
Chen Feng <puck.chen@hisilicon.com>, Fei Wang <w.f@huawei.com>
Subject: Re: [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node
Date: Tue, 12 Apr 2016 21:14:07 +0800 [thread overview]
Message-ID: <CAFGCpxyhcQEO_t+K+XSeLLL+qky8YDQbb3ewdfYY5Y=FxRy_sw@mail.gmail.com> (raw)
In-Reply-To: <20160404051653.GU17806@rob-hp-laptop>
On 4 April 2016 at 13:16, Rob Herring <robh@kernel.org> wrote:
> On Sat, Apr 02, 2016 at 05:29:41PM +0800, Guodong Xu wrote:
>> From: Chen Feng <puck.chen@hisilicon.com>
>>
>> Add the mfd hi655x dts node and regulator support on
>> hi6220 platform.
>>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
>> Signed-off-by: Fei Wang <w.f@huawei.com>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> Reviewed-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> Reviewed-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 87 ++++++++++++++++++++++++++
>> 1 file changed, 87 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 28bc646..a6dffa8 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -6,6 +6,7 @@
>> */
>>
>> /dts-v1/;
>> +#include <dt-bindings/gpio/gpio.h>
>>
>> #include "hi6220.dtsi"
>> #include "hikey-gpio.dtsi"
>> @@ -104,6 +105,92 @@
>> default-state = "off";
>> };
>> };
>> +
>> + pmic: pmic@f8000000 {
>> + compatible = "hisilicon,hi655x-pmic";
>> + reg = <0x0 0xf8000000 0x0 0x1000>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> +
>> + regulators {
>> + ldo2: LDO2@a21 {
>
> @a21 is not a unit address. Please drop these.
Will change these to
+ ldo2: LDO2 {
...
+ ldo7: LDO7 {
...
Thanks for review, Rob.
-Guodong
>
>> + regulator-name = "LDO2_2V8";
>> + regulator-min-microvolt = <2500000>;
>> + regulator-max-microvolt = <3200000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo7: LDO7@a26 {
next prev parent reply other threads:[~2016-04-12 13:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 9:29 [PATCH v2 00/16] DTS for hi6220 and HiKey Guodong Xu
2016-04-02 9:29 ` [PATCH v2 01/16] arm64: dts: Reserve memory regions for hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Guodong Xu
2016-04-03 19:23 ` Linus Walleij
2016-04-04 1:43 ` Leo Yan
2016-04-04 11:21 ` Linus Walleij
2016-04-04 13:42 ` Leo Yan
2016-04-04 13:53 ` Linus Walleij
2016-04-04 14:03 ` Leo Yan
2016-04-04 5:16 ` Rob Herring
2016-04-02 9:29 ` [PATCH v2 03/16] arm64: dts: enable idle states " Guodong Xu
2016-04-02 9:29 ` [PATCH v2 04/16] arm64: dts: Add Hi6220 gpio configuration nodes Guodong Xu
2016-04-03 19:28 ` Linus Walleij
2016-04-12 9:18 ` Guodong Xu
2016-04-02 9:29 ` [PATCH v2 05/16] arm64: dts: add Hi6220 pinctrl " Guodong Xu
2016-04-03 19:31 ` Linus Walleij
2016-04-04 22:54 ` Tony Lindgren
2016-04-02 9:29 ` [PATCH v2 06/16] arm64: dts: add Hi6220 spi " Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-12 9:40 ` Guodong Xu
2016-04-02 9:29 ` [PATCH v2 07/16] arm64: dts: add all hi6220 i2c nodes Guodong Xu
2016-04-02 9:29 ` [PATCH v2 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-02 9:29 ` [PATCH v2 09/16] arm64: dts: add hi6220 usb node Guodong Xu
2016-04-02 9:29 ` [PATCH v2 10/16] arm64: dts: add mailbox node for Hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 11/16] arm64: dts: add Hi6220's stub clock node Guodong Xu
2016-04-02 9:29 ` [PATCH v2 12/16] arm64: dts: hi6220: add pinctrl for uarts and enable them Guodong Xu
2016-04-02 9:29 ` [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-02 9:29 ` [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-12 13:14 ` Guodong Xu [this message]
2016-04-02 9:29 ` [PATCH v2 15/16] arm64: dts: add dwmmc nodes for hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 16/16] arm64: dts: add wifi nodes support for hi6220-hikey Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFGCpxyhcQEO_t+K+XSeLLL+qky8YDQbb3ewdfYY5Y=FxRy_sw@mail.gmail.com' \
--to=guodong.xu@linaro.org \
--cc=arnd.bergmann@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=puck.chen@hisilicon.com \
--cc=robh@kernel.org \
--cc=w.f@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).