From: Zhenzhong Duan <zhenzhong.duan@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
zhongjiang@huawei.com, joe@perches.com, konrad.wilk@oracle.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
will@kernel.org
Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()
Date: Mon, 4 Jan 2021 13:43:53 +0800 [thread overview]
Message-ID: <CAFH1YnMDqmOayVU8gahmndCgZtVic2JBqfoH5VQCcyya0UfCLQ@mail.gmail.com> (raw)
In-Reply-To: <20201230070244.GA22022@zn.tnic>
On Wed, Dec 30, 2020 at 3:02 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote:
> > check_iommu_entries() checks for cyclic dependency in iommu entries
> > and fixes the cyclic dependency by setting x->depend to NULL. But
> > this repairing isn't correct if q is in front of p, there will be
> > "EXECUTION ORDER INVALID!" report following. Fix it by NULLing
> > whichever in the front.
>
> When does "q is in front of p" happen? How does it happen?
Sorry, just realized it never happen.
>
> > The second issue is about the report of exectuion order reverse,
> > the order is reversed incorrectly in the report, fix it.
>
> I have no clue what that means.
I mean if p depends on q, then q->detect should be called before p->detect.
The message generated by printk() is wrong.
Regards
Zhenzhong
next prev parent reply other threads:[~2021-01-04 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 6:24 [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries() Zhenzhong Duan
2020-12-30 7:02 ` Borislav Petkov
2021-01-04 5:43 ` Zhenzhong Duan [this message]
2021-01-04 19:02 ` Konrad Rzeszutek Wilk
2021-01-07 2:51 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFH1YnMDqmOayVU8gahmndCgZtVic2JBqfoH5VQCcyya0UfCLQ@mail.gmail.com \
--to=zhenzhong.duan@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).