From: Richard Weinberger <richard.weinberger@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-um@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs
Date: Tue, 7 May 2019 23:26:38 +0200 [thread overview]
Message-ID: <CAFLxGvwb8YzNiXCXru8Tw9pxH9qoc7gAO4sk0MXK1Xmp7fm-2g@mail.gmail.com> (raw)
In-Reply-To: <20190411094944.12245-5-brgl@bgdev.pl>
On Thu, Apr 11, 2019 at 11:50 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Setting a chip for an interrupt marks it as allocated. Since UM doesn't
> support dynamic interrupt numbers (yet), it means we cannot simply
> increase NR_IRQS and then use the free irqs between LAST_IRQ and NR_IRQS
> with gpio-mockup or iio testing drivers as irq_alloc_descs() will fail
> after not being able to neither find an unallocated range of interrupts
> nor expand the range.
>
> Only call irq_set_chip_and_handler() for irqs until LAST_IRQ.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Just noticed that this triggers the following errors while bootup:
Trying to reregister IRQ 11 FD 8 TYPE 0 ID (null)
write_sigio_irq : um_request_irq failed, err = -16
Trying to reregister IRQ 11 FD 8 TYPE 0 ID (null)
write_sigio_irq : um_request_irq failed, err = -16
VFS: Mounted root (hostfs filesystem) readonly on
Can you please check?
This patch is already queued in -next. So we need to decide whether to
revert or fix it now.
next prev parent reply other threads:[~2019-05-07 21:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 9:49 [RESEND PATCH 0/4] um: build and irq fixes Bartosz Golaszewski
2019-04-11 9:49 ` [RESEND PATCH 1/4] um: remove unused variable Bartosz Golaszewski
2019-04-11 9:49 ` [RESEND PATCH 2/4] um: remove uses of variable length arrays Bartosz Golaszewski
2019-04-11 9:49 ` [RESEND PATCH 3/4] um: define set_pte_at() as a static inline function, not a macro Bartosz Golaszewski
2019-04-11 9:49 ` [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs Bartosz Golaszewski
2019-05-07 21:26 ` Richard Weinberger [this message]
2019-05-08 7:09 ` Anton Ivanov
2019-05-08 7:13 ` Richard Weinberger
2019-05-10 9:16 ` Bartosz Golaszewski
2019-05-10 16:20 ` Bartosz Golaszewski
2019-05-10 16:22 ` Anton Ivanov
2019-05-11 12:48 ` Bartosz Golaszewski
2019-04-14 7:57 ` [RESEND PATCH 0/4] um: build and irq fixes Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2019-04-03 8:38 Bartosz Golaszewski
2019-04-03 8:39 ` [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvwb8YzNiXCXru8Tw9pxH9qoc7gAO4sk0MXK1Xmp7fm-2g@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).