From: Richard Weinberger <richard.weinberger@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: nkela@cisco.com, David Woodhouse <dwmw2@infradead.org>,
xe-linux-external@cisco.com,
"linux-mtd @ lists . infradead . org"
<linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
rod@whitby.id.au
Subject: Re: [PATCH] Make JFFS2 endianness configurable
Date: Fri, 2 Nov 2018 10:28:49 +0100 [thread overview]
Message-ID: <CAFLxGvwy=ksb=GVg-D6cD40JQ1b7+RGjXH9vq8w4jB0N9rmK3Q@mail.gmail.com> (raw)
In-Reply-To: <c6b51706910048b8dd0732f8963a69867542e9a4.camel@infinera.com>
On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund
<Joakim.Tjernlund@infinera.com> wrote:
>
> On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> >
> >
> > This patch allows the endianness of the JFSS2 filesystem to be
> > specified by config options.
> >
> > It defaults to native-endian (the previously hard-coded option).
> >
> > Some architectures benefit from having a single known endianness
> > of JFFS2 filesystem (for data, not executables) independent of the
> > endianness of the processor (ARM processors can be switched to either
> > endianness at run-time).
>
> I like this too. I have on several occasions needed to mount a JFFS2 BE on
> my PC. This saves me from having to hack the src.
The feature makes sense, but I don't like it being a Kconfig option.
As Al pointed out, it should be done like UFS does.
IOW, implement a wrapper function which selects the endianness automatically.
That way you can force it as mount option or detect during mount what
kind of JFFS2
you have.
--
Thanks,
//richard
prev parent reply other threads:[~2018-11-02 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 22:56 [PATCH] Make JFFS2 endianness configurable Nikunj Kela
2018-11-02 0:02 ` Daniel Walker
2018-11-02 0:34 ` Al Viro
2018-11-02 14:04 ` Daniel Walker
2018-11-02 20:15 ` Richard Weinberger
2018-11-02 21:14 ` Daniel Walker
2018-11-02 21:22 ` Richard Weinberger
2018-11-07 1:09 ` Nikunj Kela (nkela)
2018-11-02 8:45 ` Joakim Tjernlund
2018-11-02 9:28 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLxGvwy=ksb=GVg-D6cD40JQ1b7+RGjXH9vq8w4jB0N9rmK3Q@mail.gmail.com' \
--to=richard.weinberger@gmail.com \
--cc=Joakim.Tjernlund@infinera.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nkela@cisco.com \
--cc=rod@whitby.id.au \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).