From: Richard Weinberger <richard.weinberger@gmail.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@parallels.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: show locked and lock_ro options in mountinfo
Date: Fri, 27 Mar 2015 22:42:37 +0100 [thread overview]
Message-ID: <CAFLxGvxaJdRV7c9jRhjQibyk+55GWSKyn+vuWbgXuvNSsPdQ5w@mail.gmail.com> (raw)
In-Reply-To: <1427488774-5077-1-git-send-email-avagin@openvz.org>
On Fri, Mar 27, 2015 at 9:39 PM, Andrey Vagin <avagin@openvz.org> wrote:
> I don't see any reasons to hide them. This information can help to
> understand errors.
Because these flags are set/read only internally by the VFS. In contrast
to the other flags shown by mountinfo MNT_LOCKED is not a mount option.
Why does it help to debug errors?
How would a user know that mount() with MS_BIND returns EINVAL because
the mount source is MNT_LOCKED? This information is useless for her.
If you argue like that you'd have to expose the whole VFS state to userland.
> And this information is required for correct checkpoint/restore of mount
> namespaces.
Why especially MNT_LOCKED and not all the other flags used by VFS?
Say MNT_DOOMED?
--
Thanks,
//richard
next prev parent reply other threads:[~2015-03-27 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 20:39 [PATCH] fs: show locked and lock_ro options in mountinfo Andrey Vagin
2015-03-27 21:42 ` Richard Weinberger [this message]
2015-03-27 22:35 ` Andrey Wagin
2015-03-27 22:47 ` Richard Weinberger
2015-03-31 15:15 ` Andrey Wagin
2015-03-31 21:29 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvxaJdRV7c9jRhjQibyk+55GWSKyn+vuWbgXuvNSsPdQ5w@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).