From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756961AbbAZUyb (ORCPT ); Mon, 26 Jan 2015 15:54:31 -0500 Received: from mail-vc0-f169.google.com ([209.85.220.169]:62497 "EHLO mail-vc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756170AbbAZUy3 (ORCPT ); Mon, 26 Jan 2015 15:54:29 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 26 Jan 2015 21:54:28 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] fbcon: expose cursor blink interval via sysfs From: Richard Weinberger To: Scot Doyle Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Geert Uytterhoeven , linux-fbdev@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 26, 2015 at 9:41 PM, Scot Doyle wrote: > The fbcon cursor, when set to blink, is hardcoded to toggle display state > five times per second. Expose this setting via > /sys/class/graphics/fbcon/cursor_blink_ms > > Values written to the interface set the approximate time interval in > milliseconds between cursor toggles, from 1 to 32767. Since the interval > is stored internally as a number of jiffies, the millisecond value read > from the interface may not exactly match the entered value. > > An outstanding blink timer is reset after a new value is entered. > > If the cursor blink is disabled, either via the 'cursor_blink' boolean > setting or some other mechanism, the 'cursor_blink_ms' setting may still > be modified. The new value will be used if the blink is reactivated. Out of curiosity, why do you need this new setting? Your patch describes what it does but does not describe the "why". -- Thanks, //richard