From: John Sperbeck <jsperbeck@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors
Date: Mon, 11 Feb 2019 13:43:54 -0800 [thread overview]
Message-ID: <CAFNjLiVMOii_mzs4Px38GHxFq6WnrDNhQ9YHMb+4yGZZ6SFpkQ@mail.gmail.com> (raw)
In-Reply-To: <20190211092417.7f211ee0@gandalf.local.home>
On Mon, Feb 11, 2019 at 6:24 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Sun, 10 Feb 2019 19:40:21 -0800
> John Sperbeck <jsperbeck@google.com> wrote:
>
> > If an smbus transfer fails, there's no guarantee that the output
> > buffer was written. So, avoid trying to show the output buffer when
> > tracing after an error. This was 'mostly harmless', but would trip
> > up kasan checking if left-over cruft in byte 0 is a large length,
> > causing us to read from unwritten memory.
>
> This looks fine to me, but I'm not sure how the i2c maintainers feel,
> but I always require that a new patch version starts a new thread, and
> not be part of a older thread release (causes these patches to be
> hidden from those that read patches in threading mode).
That sounds reasonable to me. Unless I hear otherwise, I'll create a
v3 as a new thread. Thanks.
prev parent reply other threads:[~2019-02-11 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 0:42 [PATCH] i2c: core-smbus: don't trace smbus_reply data on errors John Sperbeck
2019-01-04 2:49 ` Steven Rostedt
2019-02-05 12:13 ` Wolfram Sang
2019-02-05 17:19 ` John Sperbeck
2019-02-05 19:08 ` Wolfram Sang
2019-02-11 3:40 ` [PATCH v2] " John Sperbeck
2019-02-11 14:24 ` Steven Rostedt
2019-02-11 21:43 ` John Sperbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFNjLiVMOii_mzs4Px38GHxFq6WnrDNhQ9YHMb+4yGZZ6SFpkQ@mail.gmail.com \
--to=jsperbeck@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).