linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Beomho Seo <beomho.seo@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: regulator: rt5033: Question regarding define for RT5033_REGULATOR_BUCK/LOD_VOLTAGE_MAX
Date: Fri, 8 Feb 2019 20:54:40 +0800	[thread overview]
Message-ID: <CAFRkauBgVjtjJPM_5GdNTrzUymMEo180xajYwT4Duk=yxwOcbg@mail.gmail.com> (raw)

Hi Beomho,
The code has below defines in include/linux/mfd/rt5033-private.h
#define RT5033_REGULATOR_BUCK_VOLTAGE_MAX               3000000U
#define RT5033_REGULATOR_LDO_VOLTAGE_MAX                3000000U

However, according to current settings in rt5033 regulator driver:
For LDOs, it can support up to
RT5033_REGULATOR_LDO_VOLTAGE_MIN + RT5033_REGULATOR_LDO_VOLTAGE_STEP *
(RT5033_REGULATOR_LDO_VOLTAGE_STEP_NUM - 1)
= 1200000 + 100000 * 31
= 4300000 (This is different from the define of
RT5033_REGULATOR_LDO_VOLTAGE_MAX)

The same issue for BUCKs.

I don't find the datasheet, can you check which part is incorrect that
causes the inconsistent?

Thanks,
Axel

                 reply	other threads:[~2019-02-08 12:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFRkauBgVjtjJPM_5GdNTrzUymMEo180xajYwT4Duk=yxwOcbg@mail.gmail.com' \
    --to=axel.lin@ingics.com \
    --cc=beomho.seo@samsung.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).