From: Axel Lin <axel.lin@ingics.com>
To: "cy_huang(黃啟原)" <cy_huang@richtek.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"u0084500@gmail.com" <u0084500@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap
Date: Fri, 4 Jun 2021 08:13:21 +0800 [thread overview]
Message-ID: <CAFRkauCKoipBe4-QacQbjZgWuFrMPKdAfWB00Q6Lyw7xJ=6sfQ@mail.gmail.com> (raw)
In-Reply-To: <1622733524.3635.10.camel@richtek.com>
cy_huang(黃啟原) <cy_huang@richtek.com> 於 2021年6月3日 週四 下午11:18寫道:
>
> Hi,> >
> > > cy_huang(黃啟原) <cy_huang@richtek.com> 於 2021年6月3日 週四 下午6:20寫道:
> > > >
> > > >
> > > >
> > > > Hi, Axel:> Use regulator_set_ramp_delay_regmap instead of open-coded.
> > > > >
> > > > >
> > > > >
> > > > There's some reason.
> > > > You can refer to https://lkml.org/lkml/2021/6/1/1145.
> > > >
> > > > It's because our ramp value order is from small to large, not large to
> > > > small.
> > > > It conflicts with find_closest_bigger value chosen logic.
> > > I have verified the rt6160_set_ramp_delay() behavior exactly the same as
> > > regulator_set_ramp_delay_regmap. (both functions get the same selector
> > > for a given delay)
> > >
> > > Could you check if this patch works?
> > Sure.
> After my test sample code, below's the result.
> ascending [1000 2500 5000 10000]
> target = 1000 =>sel = 0
> target = 2500 =>sel = 1
> target = 5000 =>sel = 2
> target = 10000 =>sel = 3
> target = 1700 =>sel = 1
> target = 2750 =>sel = 2
> target = 7500 =>sel = 3
> target = 15000 =>failed to find best select, sel = 3
> target = 0 =>sel = 0
> descending [10000 5000 2500 1000]
> target = 1000 =>sel = 3
> target = 2500 =>sel = 2
> target = 5000 =>sel = 1
> target = 10000 =>sel = 0
> target = 1700 =>sel = 2
> target = 2750 =>sel = 1
> target = 7500 =>sel = 0
> target = 15000 =>failed to find best select, sel = 0
> target = 0 =>sel = 3
>
>
> It means when target is in range or even over, the result are all correct.
> But like as the ramp target is equal to 0, the selection will only choose the minimum one.
> When the ramp target is equal to 0, it means the user want to disable the rammpping function.
>
> As I know, if target is equal to 0, it must find the fastest rampping value as the best selection.
If your table is [1000 2500 5000 10000], find_closest_bigger() will
choose sel=0 when ramp_delay=0.
If your table is [10000 5000 2500 1000], find_closest_bigger() will
choose sel=3 when ramp_delay=0.
i.e. In both cases, find_closest_bigger() chooses the fastest ramping value.
This meets your exception.
Actually, even if your table is [10000, 1000, 5000, 2500],
find_closest_bigger() still can choose the correct selector.
i.e. sel=1 when ramp_delay=0 in this case.
Regards,
Axel
next prev parent reply other threads:[~2021-06-04 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 9:38 [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap Axel Lin
2021-06-03 10:20 ` cy_huang(黃啟原)
2021-06-03 10:28 ` Axel Lin
2021-06-03 10:41 ` cy_huang(黃啟原)
2021-06-03 10:57 ` Axel Lin
2021-06-03 15:18 ` cy_huang(黃啟原)
2021-06-04 0:13 ` Axel Lin [this message]
[not found] ` <1622773474.9011.14.camel@richtek.com>
2021-06-04 3:30 ` Axel Lin
[not found] ` <1622785727.9011.17.camel@richtek.com>
2021-06-04 5:59 ` Axel Lin
[not found] ` <1622788151.9011.20.camel@richtek.com>
2021-06-09 3:32 ` Axel Lin
2021-06-09 3:38 ` cy_huang(黃啟原)
2021-06-14 19:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFRkauCKoipBe4-QacQbjZgWuFrMPKdAfWB00Q6Lyw7xJ=6sfQ@mail.gmail.com' \
--to=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).