From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936048Ab3DPQwD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Apr 2013 12:52:03 -0400
Received: from mail-pd0-f170.google.com ([209.85.192.170]:56147 "EHLO
	mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S935928Ab3DPQwA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Apr 2013 12:52:00 -0400
MIME-Version: 1.0
X-Originating-IP: [114.40.17.142]
In-Reply-To: <1365509706.3801.1.camel@phoenix>
References: <1365509706.3801.1.camel@phoenix>
Date: Wed, 17 Apr 2013 00:51:59 +0800
Message-ID: <CAFRkauCX_0FqpHse=ic2BFkasrdL6+_hhNrNhyMboG8f-Q=EXw@mail.gmail.com>
Subject: Re: [PATCH 1/2] regulator: ab8500: Don't update info->update_val if
 write to register fails
From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
        Lee Jones <lee.jones@linaro.org>,
        Yvan FILLION <yvan.fillion@stericsson.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bengt,

This serial also needs your review.

Thanks,
Axel

2013/4/9 Axel Lin <axel.lin@ingics.com>:
> This patch ensures info->update_val is consistent with current register value.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/ab8500.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index acdffc5..1866dbf 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -392,9 +392,8 @@ static int ab8500_regulator_set_mode(struct regulator_dev *rdev,
>                         val = info->mode_val_idle;
>                         break;
>                 default:
> -                       if (info->shared_mode)
> -                               mutex_unlock(&shared_mode_mutex);
> -                       return -EINVAL;
> +                       ret = -EINVAL;
> +                       goto out_unlock;
>                 }
>
>                 bank = info->mode_bank;
> @@ -405,17 +404,14 @@ static int ab8500_regulator_set_mode(struct regulator_dev *rdev,
>
>                 switch (mode) {
>                 case REGULATOR_MODE_NORMAL:
> -                       info->update_val = info->update_val_normal;
>                         val = info->update_val_normal;
>                         break;
>                 case REGULATOR_MODE_IDLE:
> -                       info->update_val = info->update_val_idle;
>                         val = info->update_val_idle;
>                         break;
>                 default:
> -                       if (info->shared_mode)
> -                               mutex_unlock(&shared_mode_mutex);
> -                       return -EINVAL;
> +                       ret = -EINVAL;
> +                       goto out_unlock;
>                 }
>
>                 bank = info->update_bank;
> @@ -426,9 +422,11 @@ static int ab8500_regulator_set_mode(struct regulator_dev *rdev,
>         if (dmr || ab8500_regulator_is_enabled(rdev)) {
>                 ret = abx500_mask_and_set_register_interruptible(info->dev,
>                         bank, reg, mask, val);
> -               if (ret < 0)
> +               if (ret < 0) {
>                         dev_err(rdev_get_dev(rdev),
>                                 "couldn't set regulator mode\n");
> +                       goto out_unlock;
> +               }
>
>                 dev_vdbg(rdev_get_dev(rdev),
>                         "%s-set_mode (bank, reg, mask, value): "
> @@ -437,6 +435,10 @@ static int ab8500_regulator_set_mode(struct regulator_dev *rdev,
>                         mask, val);
>         }
>
> +       if (!dmr)
> +               info->update_val = val;
> +
> +out_unlock:
>         if (info->shared_mode)
>                 mutex_unlock(&shared_mode_mutex);
>
> --
> 1.7.10.4
>
>
>