From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752601AbbGOHKZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jul 2015 03:10:25 -0400
Received: from mail-lb0-f177.google.com ([209.85.217.177]:34669 "EHLO
	mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752422AbbGOHKV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jul 2015 03:10:21 -0400
MIME-Version: 1.0
X-Originating-IP: [163.26.71.6]
In-Reply-To: <1433464023.7054.1.camel@ingics.com>
References: <1433464023.7054.1.camel@ingics.com>
Date: Wed, 15 Jul 2015 15:10:20 +0800
Message-ID: <CAFRkauCjqXR0Us=aiJjxbrRP2cbU5HZCDL_O7w84FNAdUjwSHg@mail.gmail.com>
Subject: Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops
From: Axel Lin <axel.lin@ingics.com>
To: Kishon Vijay Abraham I <kishon@ti.com>, Felipe Balbi <balbi@ti.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> The ops is never changed in ulpi_phy_create(), so make it const.

Hi Kishon,

Would you pick up this patch?
Without this patch, passing a const struct phy_ops* to ulip_phy_create will
have compiler warning.
It should be fine to pass a const struct phy_ops* to ulip_phy_create and
since the drivers usually never change phy_ops after initialized,
it can be const.