linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: Lee Jones <lee.jones@linaro.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk
Date: Thu, 27 Jun 2019 10:57:24 +0800	[thread overview]
Message-ID: <CAFRkauDFf0qWpovNaaMkB48RXAsRsGEQ_=osSM7+Ze59C8DEkw@mail.gmail.com> (raw)
In-Reply-To: <40ae33d4-10fd-852a-30e6-db56d709ef1c@hisilicon.com>

Hi Chen,

Chen Feng <puck.chen@hisilicon.com> 於 2019年6月27日 週四 上午10:03寫道：
>
> Thanks
I assume this is an Ack.
If you can add your Acked-by in the reply, it's easier for maintainer to accept
the patch.

>
> On 2019/6/26 21:30, Axel Lin wrote:
> > Since devm_regmap_init_mmio_clk can fail, add return value checking.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > Acked-by: Chen Feng <puck.chen@hisilicon.com>
> > ---
> > This was sent on https://lkml.org/lkml/2019/3/6/904
> >
> >   drivers/mfd/hi655x-pmic.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > index 96c07fa1802a..6693f74aa6ab 100644
> > --- a/drivers/mfd/hi655x-pmic.c
> > +++ b/drivers/mfd/hi655x-pmic.c
> > @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
> >
> >       pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
> >                                                &hi655x_regmap_config);
> > +     if (IS_ERR(pmic->regmap))
> > +             return PTR_ERR(pmic->regmap);
> >
> >       regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
> >       if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
> >
>

  reply	other threads:[~2019-06-27  2:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 13:30 [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Axel Lin
2019-06-27  2:03 ` Chen Feng
2019-06-27  2:57   ` Axel Lin [this message]
2019-06-27 13:47     ` Lee Jones
2019-06-27 13:48 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFRkauDFf0qWpovNaaMkB48RXAsRsGEQ_=osSM7+Ze59C8DEkw@mail.gmail.com' \
    --to=axel.lin@ingics.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puck.chen@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).