From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28972C433EF for ; Mon, 22 Nov 2021 20:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240426AbhKVUUZ (ORCPT ); Mon, 22 Nov 2021 15:20:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbhKVUUW (ORCPT ); Mon, 22 Nov 2021 15:20:22 -0500 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACEE2C061574 for ; Mon, 22 Nov 2021 12:17:15 -0800 (PST) Received: by mail-ua1-x92c.google.com with SMTP id w23so39076902uao.5 for ; Mon, 22 Nov 2021 12:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posk.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o7/4mC/JYrlbPMC5mTMOllHOhZpcab+DyW/7Z03WsSM=; b=Ioe0wKMbX4DHin7wlvdFlj4MEKfvWB2K04WzO6Bh1WNDiox9t4LgjI8c+H59UvnOs6 g6OJS605i7CqxgVciSjzu013fB0T99jq7C3tGtm7+eI9k0pfTM3hyyliFvZ4o/oGmtVk /ONIaqa4lZKQgcZvJJ+g4wfgw8uXgPUNkGfTVznvQ/5dtw8rS0Gf/8/91Edb3bMSGhTt U9kWMe1MxmCVQIFNzrhgIuqDZn6NmP56OL75xQ4enV86Ocy9a8rjlBlw/wdZkq6Ve+DZ g9ZetGIVTlka2LWRrP3MZVQwNeGzf+l+BciyCZSQzS08couN26QNvInhRbxU92Vhm8m1 vZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o7/4mC/JYrlbPMC5mTMOllHOhZpcab+DyW/7Z03WsSM=; b=hKk0t4xbwll9/aqgAkoWhZozU7XZydJ0+D+QoT1uHO1lYb385PsS/Fdar+MMk6mpD6 Plf/zliWOTJItVyFu9S2ImxgbD6LNyLnkRb5yobsNR5eypJb8b38C1120v8vYFLJKDUZ gHAPQUBK08AYmAkzzTOEcIQeg6229/NHWrpu9+fpUoWXhVX0rlxvunzLd5sY9yZccSuB tD+1rAq291JGGWp+0f0zKBSC5vR0nk7WXiwiHQ5lPGUVTdlUj8nHE8ku4GQNHWiZwfdj +ggXl0cGPtPwsgCWhT9Se4K35DlO5C38Q/olTYC3jfNdQaZitV8+EbE8tduFlaXSTI8e PFXw== X-Gm-Message-State: AOAM533BVnV6vQOK2ghscI/wyYZ259N65PSrt7RI6XWcG8SVuWBgrOdp WPWq9Vh+UJ7TVzwk+mxAC2BDZTU8KVvgeKBd8mOlDQ== X-Google-Smtp-Source: ABdhPJwuthN9TtqqxsMgdNkzCamK1Lw39KDHjTILUpDel6l8BKQ6fkW7mkhQZL4NTeYgq1rYLOB385Q4dvNrEQ7NK0E= X-Received: by 2002:a05:6102:dc7:: with SMTP id e7mr133295163vst.21.1637612234866; Mon, 22 Nov 2021 12:17:14 -0800 (PST) MIME-Version: 1.0 References: <20211121212040.8649-4-posk@google.com> <202111221834.Q9LmeisY-lkp@intel.com> In-Reply-To: <202111221834.Q9LmeisY-lkp@intel.com> From: Peter Oskolkov Date: Mon, 22 Nov 2021 12:17:04 -0800 Message-ID: Subject: Re: [PATCH v0.9 3/6] sched/umcg: implement UMCG syscalls To: Peter Zijlstra Cc: Ingo Molnar , Thomas Gleixner , Andrew Morton , Dave Hansen , Andy Lutomirski , Linux Kernel Mailing List , linux-api@vger.kernel.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Paul Turner Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 22, 2021 at 2:02 AM kernel test robot wrote: > > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on cb0e52b7748737b2cf6481fdd9b920ce7e1ebbdf] > > url: https://github.com/0day-ci/linux/commits/Peter-Oskolkov/sched-mm-x86-uaccess-implement-User-Managed-Concurrency-Groups/20211122-052209 > base: cb0e52b7748737b2cf6481fdd9b920ce7e1ebbdf > config: x86_64-randconfig-c007-20211121 (attached as .config) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/e455791cacec2b140558a717d2b8b07f5561a251 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Peter-Oskolkov/sched-mm-x86-uaccess-implement-User-Managed-Concurrency-Groups/20211122-052209 > git checkout e455791cacec2b140558a717d2b8b07f5561a251 > # save the attached .config to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from :1: > >> ./usr/include/linux/umcg.h:80:2: error: unknown type name 'u64' > u64 state_ts; /* r/w */ I figured it out - lkp manages to compile uapi so that it sees __u32/__u64 but not u32/u64. I'll make the change. As __u64 is actually a different type from u64 (long unsigned int vs long long unsigned int), I'll need to make corresponding changes in other files to avoid warnings of "comparing different types" sort. Why does the kernel have both __u64 and u64, and have them defined as different types? (This is not really a question, just a complaint). > ^ > >> ./usr/include/linux/umcg.h:91:2: error: unknown type name 'u32' > u32 next_tid; /* r */ > ^ > ./usr/include/linux/umcg.h:93:2: error: unknown type name 'u32' > u32 flags; /* Reserved; must be zero. */ > ^ > ./usr/include/linux/umcg.h:101:2: error: unknown type name 'u64' > u64 idle_workers_ptr; /* r/w */ > ^ > ./usr/include/linux/umcg.h:107:2: error: unknown type name 'u64' > u64 idle_server_tid_ptr; /* r */ > ^ > 5 errors generated. > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org