From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E514E95A8E for ; Mon, 9 Oct 2023 12:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376313AbjJIM1u (ORCPT ); Mon, 9 Oct 2023 08:27:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346402AbjJIM1t (ORCPT ); Mon, 9 Oct 2023 08:27:49 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F058E for ; Mon, 9 Oct 2023 05:27:47 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-53639fb0ba4so7657062a12.0 for ; Mon, 09 Oct 2023 05:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696854466; x=1697459266; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ty9VBVWP/M8GoK0hmtHF8uhBl2FewfxHO6qc7RhyhjY=; b=VIPUzNyleyc2exnd13GiYFIzaJBhz+RVMLVFuxETNKi0V42qLvirFdHWA9DnGfO5VF jsUKpWVtA3CgaiZMUnxrbUAAmTbSlsxR+YT+BLyDqKWGVGCpT/gpOH0zsZ2tmkXrNLvp 5bND5yxPzUcs1T7A8TeReCb41eAE1Bv7aOGLGkQJXUvCHsga9DG17HePsAXWOB8L6Rjf 2jyHLm1X7jPLeplUkbVRgNKBbXWxnc8nNXuXW8IBQ6+US6PAULyyZF8wzKAHgMA5JrXm QAe3cIODxP3s7WzDNiN4/JDNei1B9JaDBxO7r4ulYU0zeGnGWXY9ATDBYSkEzcZF8UCj TzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696854466; x=1697459266; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ty9VBVWP/M8GoK0hmtHF8uhBl2FewfxHO6qc7RhyhjY=; b=LKCbSlBxrYG6wOJ/4Tt9UZDqrWH4xMxeMlbOPffHG3kQR1ZvLPa5hi+mXyTi5+/ZpX UUwR704b+ncQLS3MxyWSc+lNwmTNej5w3X7lWBVhCcnVYcYNBPQQ/sMiiRQ6suOQf6lx 8L1ZZLBUCi38VGY7Bt+cxRD5KL5y7n6+U7SO17l6k3ghM+ANpfCdjLX8oBMDJv5mBddj asyCkK6ylr/AFq4VX+O0FHvNjSTIMNqvxxUXfT+3h46vvCd+bF6MRurBmaRQlzty88vm vI9UjDIX4sLXivgDo4Srzyw3SxFX6B8BXhnEsVCxXW5KP/1E3P3b/eG8svTXzETiW0Gu FAjw== X-Gm-Message-State: AOJu0YzVjmq+Vq/mHnJCSzhUdTD3/bUlESaxjIOVwABJGoJ0Kuz5xjUU 3OhQrRaKuTTcP/zPRxMGpj5xuidzdmqlf3riPnE= X-Google-Smtp-Source: AGHT+IG9o9JvH+AKynXawGUEK6M+iY6EN51GOxtkD4b185mxdFdaN8zFqlSkv8pOIRsYFZQj7F+6sXh78aDTSDy3rtI= X-Received: by 2002:a05:6402:1b0e:b0:532:b974:671e with SMTP id by14-20020a0564021b0e00b00532b974671emr13830994edb.41.1696854465690; Mon, 09 Oct 2023 05:27:45 -0700 (PDT) MIME-Version: 1.0 References: <20231004145137.86537-1-ubizjak@gmail.com> <20231004145137.86537-5-ubizjak@gmail.com> In-Reply-To: From: Uros Bizjak Date: Mon, 9 Oct 2023 14:27:34 +0200 Message-ID: Subject: Re: [PATCH 4/4] x86/percpu: Use C for percpu read/write accessors To: Ingo Molnar Cc: Linus Torvalds , x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Nadav Amit , Brian Gerst , Denys Vlasenko , "H . Peter Anvin" , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , Josh Poimboeuf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 9, 2023 at 1:41=E2=80=AFPM Ingo Molnar wrote= : > > > * Uros Bizjak wrote: > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index ecb256954351..1edf4a5b93ca 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -2393,7 +2393,7 @@ config CC_HAS_NAMED_AS > > > > config USE_X86_SEG_SUPPORT > > def_bool y > > - depends on CC_HAS_NAMED_AS && SMP > > + depends on CC_HAS_NAMED_AS && SMP && !KASAN > > + depends on CC_HAS_NAMED_AS && SMP && !KASAN > > So I'd rather express this as a Kconfig quirk line, and explain each quir= k. > > Something like: > > depends on CC_HAS_NAMED_AS > depends on SMP > # > # -fsanitize=3Dkernel-address (KASAN) is at the moment incompatib= le > # with named address spaces - see GCC bug #12345. > # > depends on !KASAN > > ... or so. > > BTW., please also document the reason why !SMP is excluded. Eh, thanks for pointing it out, it is not needed at all, it works also for !SMP. Will fix in a Kconfig patch. Thanks, Uros.