From: Michal Lazo <michal.lazo@mdragon.org>
To: narmstrong@baylibre.com
Cc: christianshewitt@gmail.com, airlied@linux.ie,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, carlo@caione.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/meson: add support for 1080p25 mode
Date: Fri, 23 Nov 2018 14:23:30 +0100 [thread overview]
Message-ID: <CAFW1BFwocpL3brp8h66gaAiMgcCvsr1t=tU2+oNVFNOG4DMYPQ@mail.gmail.com> (raw)
In-Reply-To: <ea9d3fd1-068f-7bec-4166-9399d0aea02f@baylibre.com>
I checked 1080p30/1080p60 and values are same
I didn't check others
so clean duplicates
or make duplicates :)
On Fri, Nov 23, 2018 at 2:15 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Michal,
>
> On 23/11/2018 13:57, Michal Lazo wrote:
> > I would suggest same aproach as for
> > "meson_hdmi_encp_mode_1080p30"
> > and "meson_hdmi_encp_mode_1080p60"
> >
> > so duplicate "meson_hdmi_encp_mode_1080p50"
> > with name "meson_hdmi_encp_mode_1080p25"
>
> The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60,
> so I don't see the point about duplicating a same table for the sake of naming.
>
> We will the exact same thing to support the 2160p50/2160p60 modes by reusing the
> same config are 2160p25/2160p50, and I don't see the point of duplication the
> tables here aswell.
>
> Neil
>
> >
> > now the code looks really like common copy paste problem
> > Michal Lazo
> > On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> On 21/11/2018 10:39, Christian Hewitt wrote:
> >>> This essential mode for PAL users is missing, so add it.
> >>>
> >>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> >>> ---
> >>> drivers/gpu/drm/meson/meson_venc.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> >>> index acbbad3..ab16046 100644
> >>> --- a/drivers/gpu/drm/meson/meson_venc.c
> >>> +++ b/drivers/gpu/drm/meson/meson_venc.c
> >>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> >>> { 5, &meson_hdmi_encp_mode_1080i60 },
> >>> { 20, &meson_hdmi_encp_mode_1080i50 },
> >>> { 32, &meson_hdmi_encp_mode_1080p24 },
> >>> + { 33, &meson_hdmi_encp_mode_1080p50 },
> >>> { 34, &meson_hdmi_encp_mode_1080p30 },
> >>> { 31, &meson_hdmi_encp_mode_1080p50 },
> >>> { 16, &meson_hdmi_encp_mode_1080p60 },
> >>>
> >>
> >> Exact, I forgot this mode...
> >>
> >> Thanks for the change !
> >>
> >> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> >>
> >> I'll add :
> >> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
> >> when applying to drm-misc-fixes.
> >>
> >> Neil
> >>
> >> _______________________________________________
> >> linux-amlogic mailing list
> >> linux-amlogic@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> >
> >
> >
>
--
Best Regards
Michal Lazo
Senior developer engineer
mdragon.org
Slovakia
next prev parent reply other threads:[~2018-11-23 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 9:39 [PATCH] drm/meson: add support for 1080p25 mode Christian Hewitt
2018-11-21 9:47 ` Neil Armstrong
2018-11-23 12:57 ` Michal Lazo
2018-11-23 13:15 ` Neil Armstrong
2018-11-23 13:23 ` Michal Lazo [this message]
2018-11-26 8:52 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFW1BFwocpL3brp8h66gaAiMgcCvsr1t=tU2+oNVFNOG4DMYPQ@mail.gmail.com' \
--to=michal.lazo@mdragon.org \
--cc=airlied@linux.ie \
--cc=carlo@caione.org \
--cc=christianshewitt@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).