From: Harini Katakam <harinikatakamlinux@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Harini Katakam <harini.katakam@xilinx.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
netdev@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>,
"michals@xilinx.com" <michals@xilinx.com>
Subject: Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings
Date: Sat, 14 May 2016 08:20:35 +0530 [thread overview]
Message-ID: <CAFcVECJjHRYUmtN3Gha-zNz+4JvXRH-BY+eEumdboaREp1D4Ow@mail.gmail.com> (raw)
In-Reply-To: <20160513174300.GB7600@lunn.ch>
HI Andrew,
On Fri, May 13, 2016 at 11:13 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> Hi Harini
>
> Is this backward compatible? Will devices using the old binding still
> work?
It isn't right now.
I will have to assign the bus read/write functions conditionally in order to
do that - I'll see if I can make it clean.
>
> /* Disable RX and TX (XXX: Should we halt the transmission
> * more gracefully?)
> */
> - macb_writel(bp, NCR, 0);
> + ctrl = macb_readl(bp, NCR);
> + ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
> + macb_writel(bp, NCR, ctrl);
>
> /* Clear the stats registers (XXX: Update stats first?) */
> - macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
> + ctrl |= MACB_BIT(CLRSTAT);
> + macb_writel(bp, NCR, ctrl);
>
> /* Clear all status flags */
> macb_writel(bp, TSR, -1);
>
> It is not clear to me what this part has to do with MDIO.
>
Sorry, I'll move this to a separate patch in my next version.
It is intended to write those registers without disturbing reserved bits.
Regards,
Harini
next prev parent reply other threads:[~2016-05-14 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 9:26 [RFC PATCH 1/2] net: macb: Add MDIO driver for accessing multiple PHY devices Harini Katakam
2016-05-13 9:26 ` [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Harini Katakam
2016-05-13 17:36 ` Andrew Lunn
2016-05-13 17:43 ` Andrew Lunn
2016-05-14 2:50 ` Harini Katakam [this message]
2016-11-28 9:49 Harini Katakam
2016-12-03 21:35 ` Rob Herring
2016-12-03 22:40 ` Florian Fainelli
2016-12-05 3:03 ` Harini Katakam
2016-12-05 2:55 ` Harini Katakam
2016-12-05 10:23 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFcVECJjHRYUmtN3Gha-zNz+4JvXRH-BY+eEumdboaREp1D4Ow@mail.gmail.com \
--to=harinikatakamlinux@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=harini.katakam@xilinx.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).