From: Harini Katakam <harinikatakamlinux@gmail.com>
To: Rafal Ozieblo <rafalo@cadence.com>
Cc: Andrei Pistirica <andrei.pistirica@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"nicolas.ferre@atmel.com" <nicolas.ferre@atmel.com>,
"harini.katakam@xilinx.com" <harini.katakam@xilinx.com>,
"punnaia@xilinx.com" <punnaia@xilinx.com>,
"michals@xilinx.com" <michals@xilinx.com>,
"anirudh@xilinx.com" <anirudh@xilinx.com>,
"boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"alexandre.belloni@free-electrons.com"
<alexandre.belloni@free-electrons.com>,
"tbultel@pixelsurmer.com" <tbultel@pixelsurmer.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
Date: Fri, 27 Jan 2017 11:12:43 +0530 [thread overview]
Message-ID: <CAFcVECLuWM65zXJWtMcwijZ1ZbtH0pvKnTUR=SJagPGHEr9amg@mail.gmail.com> (raw)
In-Reply-To: <BN3PR07MB25160FCBCF19918C495F43B4C9770@BN3PR07MB2516.namprd07.prod.outlook.com>
Hi Rafal,
On Thu, Jan 26, 2017 at 8:45 PM, Rafal Ozieblo <rafalo@cadence.com> wrote:
>> -----Original Message-----
>> From: Andrei Pistirica [mailto:andrei.pistirica@microchip.com]
>> Sent: 19 stycznia 2017 16:56
>> Subject: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>>
>>
>> +static inline bool gem_has_ptp(struct macb *bp)
>> +{
>> + return !!(bp->caps & MACB_CAPS_GEM_HAS_PTP);
>> +}
> Why don't you use hardware capabilities here? Would it be better to read it from hardware instead adding it to many configuration?
If you are referring to TSU bit in DCFG5, then we will be relying on
Cadence IP's information irrespective of the SoC capability
and whether the PTP support was adequate.
I think the capability approach gives better control and
it is not really much to add.
Regards,
Harini
next prev parent reply other threads:[~2017-01-27 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 15:56 [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Andrei Pistirica
2017-01-19 16:07 ` Nicolas Ferre
2017-01-25 9:26 ` Nicolas Ferre
2017-01-25 9:37 ` Harini Katakam
2017-01-26 15:15 ` Rafal Ozieblo
2017-01-27 5:42 ` Harini Katakam [this message]
2017-01-27 10:12 ` Nicolas Ferre
2017-01-27 10:26 ` Rafal Ozieblo
2017-01-27 10:27 ` Nicolas Ferre
2017-01-27 11:06 ` Rafal Ozieblo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFcVECLuWM65zXJWtMcwijZ1ZbtH0pvKnTUR=SJagPGHEr9amg@mail.gmail.com' \
--to=harinikatakamlinux@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrei.pistirica@microchip.com \
--cc=anirudh@xilinx.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=harini.katakam@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=punnaia@xilinx.com \
--cc=rafalo@cadence.com \
--cc=richardcochran@gmail.com \
--cc=tbultel@pixelsurmer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).