From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4686AC433F5 for ; Thu, 10 Mar 2022 08:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240233AbiCJILh (ORCPT ); Thu, 10 Mar 2022 03:11:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbiCJILe (ORCPT ); Thu, 10 Mar 2022 03:11:34 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320B813396D for ; Thu, 10 Mar 2022 00:10:34 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id bg10so10333154ejb.4 for ; Thu, 10 Mar 2022 00:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ig5zBgV9456yZCmUhF8sBV7DGvRjdoa/kYWf35qIWfM=; b=gPCSxtOtkcm9lBcjKc3oEYW0bwIOPUjo/9v8mv6bIvRIKpp5KNbPSY1T5xU3ivvuVN k+xyt8opyuQ3TJKg2sQUmD4PPlOP3IT7LQammSIoRfwRLzXbtMlA2VGubvJPWKUES4Gg aAKRsund5DIxnpC/4Etq+A4zKMFKOcBjfGEdc0i5tlN9SpgaDe1HNoH9sXxEfXph7ajw 8K7xkbSrZj8vk3LWmiUuqrY2Omeu4u+mPdl/6uje+nXWagXWGflDpRpXvXDJvy9R+LXz x98cLR7hdd8fXjQy1/ZbXP7eLvEqR4tL+4apb5i8ArRvmDDNc7UYYskI0kXNcpZW+cI4 VKQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ig5zBgV9456yZCmUhF8sBV7DGvRjdoa/kYWf35qIWfM=; b=VEyLP2MOWxka0bQUw1JqSrGPFbg6lK/yTbmmmcDDRqG+WVdXuid+xD8NQNwM2Fjnyp 57+1RPfBqqaKCDEKCKpZecg9JHSM/uSIW/xUOnpwRv4PzRwEppMtv9vi9UtkUfmAoe9e wfGORY8qHduC5/rQsb7g2cIy5IGXghfOuabcjLusbc9ZX964itefN3HuJ9H8lppIg1L0 2Uc5ufi9y+JY6E2v8ZWuOx03RyPmwdylDzYlrKk4rVgPqE0fGvohBkxWuFNbTpLu1Dx4 ifNDdc462XAM2icJCrOTWA7llmFf2yXvZKdsoRcYfm7t/UmsYReVE09QYNta7it3I2cC 4NdA== X-Gm-Message-State: AOAM530Pod4D5PddnYf2+9KW5vc+Hv4KCdEYPFXVWeuEpt6w8yJJW1Dn 5fQ45cIpjV4KvFuR6lh9/CGcLjGTB1pb7MQfPHvAlw== X-Google-Smtp-Source: ABdhPJwWjyB4q5JB3+aDamJ9NuChwaNJ1qU/nXjWsKLHQQ+N2KuIi2D9W0C1teF+lT6fDaFrqnctNJAMDW7/NepL5GQ= X-Received: by 2002:a17:906:2899:b0:6d6:e479:1fe2 with SMTP id o25-20020a170906289900b006d6e4791fe2mr3156352ejd.394.1646899832564; Thu, 10 Mar 2022 00:10:32 -0800 (PST) MIME-Version: 1.0 References: <20220309083753.1561921-1-liupeng256@huawei.com> <20220309083753.1561921-3-liupeng256@huawei.com> In-Reply-To: <20220309083753.1561921-3-liupeng256@huawei.com> From: Brendan Higgins Date: Thu, 10 Mar 2022 03:10:21 -0500 Message-ID: Subject: Re: [PATCH v2 2/3] kunit: make kunit_test_timeout compatible with comment To: Peng Liu Cc: glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 9, 2022 at 3:19 AM 'Peng Liu' via KUnit Development wrote: > > In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC" > represent 5min. However, it is wrong when dealing with arm64 whose > default HZ = 250, or some other situations. Use msecs_to_jiffies to > fix this, and kunit_test_timeout will work as desired. > > Fixes: 5f3e06208920 ("kunit: test: add support for test abort") > Signed-off-by: Peng Liu Reviewed-by: Brendan Higgins