From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30451C433EF for ; Wed, 6 Jul 2022 20:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233644AbiGFUGr (ORCPT ); Wed, 6 Jul 2022 16:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231724AbiGFUGp (ORCPT ); Wed, 6 Jul 2022 16:06:45 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FA6F1EEF5 for ; Wed, 6 Jul 2022 13:06:44 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id z41so20654299ede.1 for ; Wed, 06 Jul 2022 13:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7PiCfuqqFQMm4Z7Pxo/Mkp0vSHbF19ROVfmwHiEwIp8=; b=nP8OozGQwV0hugk+1RizuLBuHeDBhO9I1ymaTbz9SVKu5nYndfbg6U0LGPb6gwFfHJ ToZbABTlGJpV7Fyk+IMRHWjt2JHxQ45DWhkDuCmFXEEaQbf6RfOr5CSueAaKi6gUsh5a Re0l7tzCHIGJ1Dw5CTE7fLIk/lTWUfy8Zu6/EVTWwCBo21YLl5rgE+ag9/k0RxO6uPdv GIBGew/Ulw3raH0Q/cIqfI03t9KZH/OVjZiX7syD/4LdZeoIB5GkytSbgTT0CvCF6QEF nNNtaoJCr1mmiucox/7veCDibYCx6ha7KADLG+MsqE7dMs9RavPoTfk7C/J1RzUZvtv6 dOFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7PiCfuqqFQMm4Z7Pxo/Mkp0vSHbF19ROVfmwHiEwIp8=; b=sw4mz7Ve9G4ZHdOnFMC+nQIoymDTzuDCoz05lbLoH2+ImEICZzH6qZah5aPFwd944L kJ90eUz1YvK3aSacNbO4w0vezWESjdz+p0pUUCw9aIYAhuU/jbrnmkYXDykAYgfJiDzO jdIp97WHTHXcpkO6MBgShVjmnVWJqerlVDpBa1kkNjbOlSefSFR3XjHu9Ok1Aw4+q4UA l9vbZtc2uaQTbpRdhPUCKNj1+jx96fSLnh8RJFplQpCExj+tIbIa33qL7reHXlmA5Eot GXLJaafv4UjoOqneikb6OSrNrBJSf9pAa8tVDWFcEK9FNh2wNmFHKxbEQQ8uYAhq/gAC Rp+g== X-Gm-Message-State: AJIora9bXtj5wfm1KQbEwCFTL0n+y4MFCdVker2H6t5lmL+6wrnioAdB eGRCWNNHPxr2yluKiAyaxcvBmj0WCDsko7aFXC9c7g== X-Google-Smtp-Source: AGRyM1vVw8FO9mBPy3IYwxvYYV3o1j35+YKTnPDfsskfWqT5lbva7gMmrRyi07uXl3B4HhdRXqCM45LkaGsIUGz65VE= X-Received: by 2002:a05:6402:40c3:b0:439:6b72:483e with SMTP id z3-20020a05640240c300b004396b72483emr43951638edb.154.1657138003142; Wed, 06 Jul 2022 13:06:43 -0700 (PDT) MIME-Version: 1.0 References: <20220518170124.2849497-1-dlatypov@google.com> <20220518170124.2849497-3-dlatypov@google.com> In-Reply-To: <20220518170124.2849497-3-dlatypov@google.com> From: Brendan Higgins Date: Wed, 6 Jul 2022 16:06:31 -0400 Message-ID: Subject: Re: [PATCH 2/3] kunit: tool: simplify creating LinuxSourceTreeOperations To: Daniel Latypov Cc: davidgow@google.com, elver@google.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 1:01 PM Daniel Latypov wrote: > > Drop get_source_tree_ops() and just call what used to be > get_source_tree_ops_from_qemu_config() in both cases. > > Also rename the functions to have shorter names and add a "_" prefix to > note they're not meant to be used outside this function. > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins