From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2405C606C7 for ; Mon, 8 Jul 2019 18:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FAA821852 for ; Mon, 8 Jul 2019 18:13:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OgF8cL2j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390376AbfGHSNJ (ORCPT ); Mon, 8 Jul 2019 14:13:09 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42974 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388905AbfGHSNH (ORCPT ); Mon, 8 Jul 2019 14:13:07 -0400 Received: by mail-pf1-f196.google.com with SMTP id q10so7976478pff.9 for ; Mon, 08 Jul 2019 11:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JCk1WdM0E6nhQWvL7vJ1kxAIGG56jCba8QRd4SGiDCA=; b=OgF8cL2jlYPassQya/5LPanMn4rdt4wOzgmrqwzZxEQPZIqKVwIc/cbAKjQaKs4FzI MO+lSWFVjE1BjbNrUM+omMAeEVXWMjykV41krvzt8AWSDOTa5viWTuQtJ9ep0X0LXNYj OdiZ626za04Q5e0ee0vw+VtEjSvuMHfSSgdE6F33EKsPb+2cKBbfbxgMScj9OazVWVAS RUi9fLCfATh+IjCkIXVEG9DerSHN7LKc7YsX4AxnaewNdUelqDZmIgeZ0zeSR0DCe4sE eOaHDJj5UB+8gGaq9GRuZY4qOho86pU0SRPsJdJUsDSn1VzYLTJqJx6RyW6gChbKWFWj 8y+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JCk1WdM0E6nhQWvL7vJ1kxAIGG56jCba8QRd4SGiDCA=; b=qYxLHKXnrKdurP4wBIjku9joghkZGQ7Iw1ICBpgfYlUFYw8iNMcEBAcHxudgLpTBln x9aScttpgI+Ak5N+/aexID00EPrkeZnq085DYnddMd6EAx8zo/3pm67m2HwIAKNdb/3D u3M7lBYov4r+W/8WjFikivOyF2/gNdw3zdfla0cii8N1qzDW795P131dBXJjpQZRgPpu ZEyVL5jKw/aFR1518vuxDLh9L3541GX4qA+JpZKzZsW6OQclTcKRFAcTPw89g3SJAEuT Yqs56580EmLbKCuxL6/OkXJIv4+UdqYhWpuHCmhblzfc9up9lQeRRYW1TNwPo3GUH2jD cJXA== X-Gm-Message-State: APjAAAXyxwsgV6pQmlt5g6rGfZNZZ9zl98AZWybxicIDVqZ5/aliRGxc 9skJ6xTyWRakVmOGon6Mv9l9nspt3bacRvMBBazGlA== X-Google-Smtp-Source: APXvYqwC0igtuHeVBLKgctH3AD+JJSF1DFvHIy3IKlb3b8t5WGygrYUkxCrtO7R9CSN2ItDaerVKeb0U4IrWm5FTm44= X-Received: by 2002:a17:90b:f0e:: with SMTP id br14mr27407161pjb.117.1562609586818; Mon, 08 Jul 2019 11:13:06 -0700 (PDT) MIME-Version: 1.0 References: <20190704003615.204860-1-brendanhiggins@google.com> <20190704003615.204860-2-brendanhiggins@google.com> <20190705202051.GB19023@42.do-not-panic.com> In-Reply-To: <20190705202051.GB19023@42.do-not-panic.com> From: Brendan Higgins Date: Mon, 8 Jul 2019 11:12:55 -0700 Message-ID: Subject: Re: [PATCH v6 01/18] kunit: test: add KUnit test runner core To: Luis Chamberlain Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Peter Zijlstra , Rob Herring , Stephen Boyd , shuah , "Theodore Ts'o" , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 5, 2019 at 1:20 PM Luis Chamberlain wrote: > > On Wed, Jul 03, 2019 at 05:35:58PM -0700, Brendan Higgins wrote: > > +struct kunit { > > + void *priv; > > + > > + /* private: internal use only. */ > > + const char *name; /* Read only after initialization! */ > > + bool success; /* Read only after test_case finishes! */ > > +}; > > No lock attribute above. > > > +void kunit_init_test(struct kunit *test, const char *name) > > +{ > > + spin_lock_init(&test->lock); > > + test->name = name; > > + test->success = true; > > +} > > And yet here you initialize a spin lock... This won't compile. Seems > you forgot to remove this line. So I guess a re-spin is better. Oh crap, sorry about that. You can't compile these patches until the kbuild patch. I will fix this and make sure I didn't make any similar mistakes on these early patches. Thanks!