From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA24C3F2D7 for ; Thu, 5 Mar 2020 21:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6416A20728 for ; Thu, 5 Mar 2020 21:25:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PD4/aQa2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbgCEVZy (ORCPT ); Thu, 5 Mar 2020 16:25:54 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41870 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgCEVZx (ORCPT ); Thu, 5 Mar 2020 16:25:53 -0500 Received: by mail-pf1-f193.google.com with SMTP id z65so2877995pfz.8 for ; Thu, 05 Mar 2020 13:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ajV8smT+f8sjiZ+RvnRGvGz6QEWErk3TEm6WtYdFaY4=; b=PD4/aQa2ZLv3yStD0yB0ftfKVsfmPuxn8sddykSIcKSP9k2S2SZgmSvtk8Qci/seRO zqp5VQs2trR7GQT47cRxPmyfkGpOr1b3cIU7oNlG9BiSxtJ8g9XbFwC7yCzfX0vjbrVF vVLzXjnDDrax6SOgUnuX7AYkLp8DzaM6zHAYLTE/oVrRB6KSPxrG6pDr/vYvAPeXAWON vk91gC4iqYvNoX0rby45VaGLhvZsdXjuscR6G/+mSMtxAx+6YH/D2Ffeq0wT0uI5M/e7 h1qNUtTmRaRWW+jieeapG55XxcQO5J+WRABXUC116zlQr85Vfgx3FZKLrL3HZovRQizK YH2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ajV8smT+f8sjiZ+RvnRGvGz6QEWErk3TEm6WtYdFaY4=; b=qte2Dt5hwwLJgoxMe4lu05dfDuORKnG08tqddP0zK2IbpbvvaCcQdSWAPIA6j+Yv9/ IdO3KyoK8P8r+ZPuOgbYBExIa2I/RAYPove0v1LuHrHByFzT5q05piCkzoaW+PLA2aSA cHtckHUAFV6U26+fl1vciLU6d6vyMu8Fa0+Fbb5+x0NNnD07Tp6kWeBjCKePT20c5YZS a8bw494zWOEwxiOPcR07SaDzOkWAV861TbSlD31iRb7yiQjlQ288fK8VOXzeL3QaqArI XVrQDjySoTqDOOCjhJKuUeykijqCUK6+US6CYnfD+KqQsV79Pkj2E3vCCeHUbVJoS7vO RCkQ== X-Gm-Message-State: ANhLgQ1/N+PN9CAGp0gnL0FZSHQq7+Rgrz9bg5gl7BY10x/LIXQCc1KG a89Hd0av7LroLpgccWF6gMkqXyhf6k0SNrxWbpZF41rLEKQ= X-Google-Smtp-Source: ADFU+vs/yd8sl8AGOF4udEAV6HbPfrhJNTZpdS0+B2FFxE8/Db+V/XPyzKCC8/zYHslLQzpePU8Xrg+lyAT+TBlzx7k= X-Received: by 2002:a63:6cc6:: with SMTP id h189mr98575pgc.201.1583443552247; Thu, 05 Mar 2020 13:25:52 -0800 (PST) MIME-Version: 1.0 References: <20200305200409.239406-1-heidifahim@google.com> In-Reply-To: <20200305200409.239406-1-heidifahim@google.com> From: Brendan Higgins Date: Thu, 5 Mar 2020 13:25:41 -0800 Message-ID: Subject: Re: [PATCH v2 1/2] kunit: kunit_parser: make parser more robust To: Heidi Fahim Cc: Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 5, 2020 at 12:04 PM Heidi Fahim wrote: > > Previously, kunit_parser did not properly handle kunit TAP output that > - had any prefixes (generated from different configs e.g. > CONFIG_PRINTK_TIME) > - had unrelated kernel output mixed in the middle of > it, which has shown up when testing with allyesconfig > To remove prefixes, the parser looks for the first line that includes > TAP output, "TAP version 14". It then determines the length of the > string before this sequence, and strips that number of characters off > the beginning of the following lines until the last KUnit output line is > reached. > These fixes have been tested with additional tests in the > KUnitParseTest and their associated logs have also been added. > > Signed-off-by: Heidi Fahim Reviewed-by: Brendan Higgins Thanks!