From: Brendan Higgins <brendanhiggins@google.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: Marco Elver <elver@google.com>,
glittao@gmail.com, cl@linux.com, penberg@kernel.org,
David Rientjes <rientjes@google.com>,
iamjoonsoo.kim@lge.com, Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality
Date: Fri, 2 Apr 2021 02:38:25 -0700 [thread overview]
Message-ID: <CAFd5g45h46ozAaDunBhxM-ianoo7_aVCK09o-9Otd5fBJU5L2A@mail.gmail.com> (raw)
In-Reply-To: <CAGS_qxpWtNLJ7_i5pDYhiGq_Jy+oPPc+HpWjNTJKAPyvQf+gsQ@mail.gmail.com>
On Thu, Apr 1, 2021 at 12:04 PM 'Daniel Latypov' via KUnit Development
<kunit-dev@googlegroups.com> wrote:
>
> On Thu, Apr 1, 2021 at 2:16 AM 'Marco Elver' via KUnit Development
> <kunit-dev@googlegroups.com> wrote:
[...]
> > #else
> > static inline bool slab_add_kunit_errors(void) { return false; }
> > #endif
> >
> > And anywhere you want to increase the error count, you'd call
> > slab_add_kunit_errors().
> >
> > Another benefit of this approach is that if KUnit is disabled, there is
> > zero overhead and no additional code generated (vs. the current
> > approach).
>
> The resource approach looks really good, but...
> You'd be picking up a dependency on
> https://lore.kernel.org/linux-kselftest/20210311152314.3814916-2-dlatypov@google.com/
> current->kunit_test will always be NULL unless CONFIG_KASAN=y &&
> CONFIG_KUNIT=y at the moment.
> My patch drops the CONFIG_KASAN requirement and opens it up to all tests.
>
> At the moment, it's just waiting another look over from Brendan or David.
> Any ETA on that, folks? :)
I just gave a "Reviewed-by" and sent it off to Shuah. Should be
available in 5.13.
Cheers
prev parent reply other threads:[~2021-04-02 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:51 [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality glittao
2021-03-31 8:51 ` [PATCH v3 2/2] slub: remove resiliency_test() function glittao
2021-04-01 7:41 ` [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality Vlastimil Babka
2021-04-01 9:16 ` Marco Elver
2021-04-01 19:04 ` Daniel Latypov
2021-04-01 21:24 ` Marco Elver
2021-04-06 10:57 ` Vlastimil Babka
2021-04-08 10:29 ` Marco Elver
2021-04-08 17:19 ` Daniel Latypov
2021-04-09 7:54 ` Brendan Higgins
2021-04-02 9:38 ` Brendan Higgins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g45h46ozAaDunBhxM-ianoo7_aVCK09o-9Otd5fBJU5L2A@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dlatypov@google.com \
--cc=elver@google.com \
--cc=glittao@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).