From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752118AbdIFITP (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Sep 2017 04:19:15 -0400
Received: from mail-qk0-f172.google.com ([209.85.220.172]:34822 "EHLO
        mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751345AbdIFITM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Sep 2017 04:19:12 -0400
X-Google-Smtp-Source: ADKCNb7GiSGGeGMTEwmx69SxSOfdLRHMym0m9NwpqcZ77exLqJiGLdCAneVbKfc1gI5HQ2hgrJQS1lxDuYVEqGO6Hck=
MIME-Version: 1.0
In-Reply-To: <CACPK8Xc0jrnx96=BoGMwQgoT2brgc0UTNU5HMHXDeFfeToVgxA@mail.gmail.com>
References: <20170906003016.2159-1-brendanhiggins@google.com>
 <20170906003016.2159-3-brendanhiggins@google.com> <CACPK8Xc0jrnx96=BoGMwQgoT2brgc0UTNU5HMHXDeFfeToVgxA@mail.gmail.com>
From: Brendan Higgins <brendanhiggins@google.com>
Date: Wed, 6 Sep 2017 01:19:11 -0700
Message-ID: <CAFd5g45s6yo=HSut76YknOkUeKbV8yOXWbivc=EyM2s7R8DOrA@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree
To: Joel Stanley <joel@jms.id.au>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>, avifishman70@gmail.com,
        tmaimon77@gmail.com, Rick Altherr <raltherr@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 5, 2017 at 10:23 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins
> <brendanhiggins@google.com> wrote:
>> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt
>> @@ -0,0 +1,6 @@
>> +NPCM Platforms Device Tree Bindings
>> +-----------------------------------
>> +NPCM750 SoC
>> +Required root node properties:
>> +       - compatible = "nuvoton,npcm750";
>> +
>
> This is minimal. I assume there will be more content added as more
> support is added?

Yep, that's the plan. They have a number of similar BMCs, both those
based on different ARM cores and some with different peripheral sets,
so we will probably want to have different compat strings for those.

>
> Does it need it's own directory?

Not sure, I saw that some of the other architectures did it, some did
not. I don't feel strongly about it.

>
>
>> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> new file mode 100644
>> index 000000000000..54df32cff21b
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>
>> +
>> +/dts-v1/;
>> +#include "nuvoton-npcm750.dtsi"
>> +
>> +/ {
>> +       model = "Nuvoton npcm750 Development Board (Device Tree)";
>> +       compatible = "nuvoton,npcm750";
>> +
>> +       chosen {
>> +               stdout-path = &serial3;
>> +               bootargs = "earlyprintk=serial,serial3,115200";
>> +       };
>> +
>> +       memory {
>> +               reg = <0 0x40000000>;
>> +       };
>> +
>> +       cpus {
>> +               enable-method = "nuvoton,npcm7xx-smp";
>> +       };
>> +
>> +       clk: clock-controller@f0801000 {
>> +               status = "okay";
>> +       };
>> +
>> +       apb {
>> +               watchdog1: watchdog@f0009000 {
>> +                       status = "okay";
>> +               };
>
> You've already got the label for the node, is there are reason you
> don't use a phandle to set the status?

Addressed in v4.

>
> &watchdog1 {
>    status = "okay";
> };
>
> Same with the serial nodes below.
>
>> +
>> +               serial0: serial0@f0001000 {
>> +                       status = "okay";
>> +               };
>> +
>> +               serial1: serial1@f0002000 {
>> +                       status = "okay";
>> +               };
>> +
>> +               serial2: serial2@f0003000 {
>> +                       status = "okay";
>> +               };
>> +
>> +               serial3: serial3@f0004000 {
>> +                       status = "okay";
>> +               };
>> +       };