From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037DEC432C0 for ; Tue, 3 Dec 2019 23:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2D4620684 for ; Tue, 3 Dec 2019 23:08:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iXMrnw93" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728848AbfLCWpW (ORCPT ); Tue, 3 Dec 2019 17:45:22 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42343 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728773AbfLCWpP (ORCPT ); Tue, 3 Dec 2019 17:45:15 -0500 Received: by mail-pf1-f194.google.com with SMTP id l22so2556509pff.9 for ; Tue, 03 Dec 2019 14:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qd7P+RAsKeedZrqHSNazeNqcDpe7+eVvkyWsa2Q207Q=; b=iXMrnw93nP/soNBqfRzeL/LguWO2PkOg2jKyU1LfmhQ8cwNGaFd8qWTj1ngdPLbuZs 2V4t+5GyeScz7/QEokG4fQ+4fgTCRXC5hc6v+uUyIW/eepTWFvSu+HQA017iTYKOaN1t fNOxy5KxTaiI/RBqvWjCH8e03nPVxe/jBysKTJWN9v9olf6QeUWbxPqaMdVSFELa+ZnT Yh8wD4+Cagsxb4NudI+PNBY6O5OnrZ7ihaB8UKAHI4Xq1X7o2bVir7T3/0hy0/wiWvJR 2qSKD1ImpOVpVwTR7efn5Oxc4qTw24IFdfabSYnAt8ljytwn9zlOfL5FjtOq2T+VwFa5 DMmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qd7P+RAsKeedZrqHSNazeNqcDpe7+eVvkyWsa2Q207Q=; b=S84n0KvfBj5y/0HeYkMtHMPj52nMulE9GZCHM4/FzHVG8gBW1b7JsYlzcJu7QSZ1LK eGl7kUmF02k2SZUwUOoU4iDpEnyxUt5ithG6suOg8nCZGjj+vEtGea2lTcNSfziugXvW JTjNCbLZhFezvaDkbVhMd0rdT14gRfxMXCQna4Vo3ifSaD0qx5EClFOl6Uxmq7UjJz43 ly//BfE/Z3J6dcsWo3iFr6bBMpDW+PovK6YJKxGW4JYk7tMxWLZ54sVD98lgPZiEFLW7 +H1Wrt67H0UhB8RXzUY0lbkUaihoYvK5C0288cpeeO6v1SIbdzWv5Z86sNU8fhIjJche laQQ== X-Gm-Message-State: APjAAAWBodaLM8TRRBNp3hkRm58c9f1Z/Xjy+mh5euH4LDMO3BSeCrgX Osy45+1RHl8PV2EQH2gFaQ7Y7AbUcXrFpI+P9Wj48ypbGGGS3g== X-Google-Smtp-Source: APXvYqwcKBHbJdc+KCshtot/o7I0++tDm8qDfLRf4tv06Kw+/aPlM9T1C8nXAryH6sAPWx+2axjFe1oWQ0uD10x8T1Q= X-Received: by 2002:a63:480f:: with SMTP id v15mr22272pga.201.1575413114597; Tue, 03 Dec 2019 14:45:14 -0800 (PST) MIME-Version: 1.0 References: <1575374868-32601-1-git-send-email-alan.maguire@oracle.com> <1575374868-32601-5-git-send-email-alan.maguire@oracle.com> In-Reply-To: <1575374868-32601-5-git-send-email-alan.maguire@oracle.com> From: Brendan Higgins Date: Tue, 3 Dec 2019 14:45:03 -0800 Message-ID: Subject: Re: [PATCH v5 linux-kselftest-test 4/6] kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds To: Alan Maguire Cc: "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , KUnit Development , Kees Cook , Iurii Zaikin , Andrew Morton , Masahiro Yamada , catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, urezki@gmail.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , David Gow , adilger.kernel@dilger.ca, "Theodore Ts'o" , Luis Chamberlain , "open list:DOCUMENTATION" , Knut Omang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 3, 2019 at 4:08 AM Alan Maguire wrote: > > In discussion of how to handle timeouts, it was noted that if > sysctl_hung_task_timeout_seconds is exceeded for a kunit test, > the test task will be killed and an oops generated. This should > suffice as a means of debugging such timeout issues for now. > > Hence remove use of sysctl_hung_task_timeout_secs, which has the > added benefit of avoiding the need to export that symbol from > the core kernel. > > Co-developed-by: Knut Omang > Signed-off-by: Knut Omang > Signed-off-by: Alan Maguire > Reviewed-by: Stephen Boyd Acked-by: Brendan Higgins