From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E5FC43334 for ; Wed, 6 Jul 2022 18:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234657AbiGFSfS (ORCPT ); Wed, 6 Jul 2022 14:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234533AbiGFSe5 (ORCPT ); Wed, 6 Jul 2022 14:34:57 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91C432613B for ; Wed, 6 Jul 2022 11:34:55 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id r6so8931428edd.7 for ; Wed, 06 Jul 2022 11:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG8GWm0pmr1Neu+cMWEfjz23I2y6CFYI8JxXePQozTs=; b=K6UVv820cw4CP15PiN8DijrpJiKXTK2nYW2xtVIQZTStYnHOZp1tjf20TsCZCG4HGr RZafD5eelpwYaHVcAyMuETGjixhszK4DQ6YKv+Q80G1fKFpt+G0t+ngcqsJyYT7nhalp Tt5yhV6pPeJFmbW/z+5gHkZta0h1PghK059lHia6BlfJdTtC1KiwQBLWh5RB4eluxNoP q912y26LeH0Graq9HfNSoI2iFrXc2npjKA+rDzeeExj9ItUikpyIwH8W2zqTSxqSlqkR uC+MqbwYAJWSLMTs6wWURW91QD/UdbvDNtMO/K16eQfzcaeADys3RXFvbp4d2iZV/J0Q Kf8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG8GWm0pmr1Neu+cMWEfjz23I2y6CFYI8JxXePQozTs=; b=qjjZPm+REnJMcR45Gkfq+7M9EaHR/T+/HxIKqO9yVyb6qT+s0iP+x99/V7EXDWq+iz 6d3y5BmnOq8Aso0+/sUT3LfDsV9PvSNRedFotWsbixuc1xH7IE5ISdTx3iiivOzhDBxr jTu5noNVIqcrp8vZ3ZapwMyHE8xkosZsXBj3INcI9W5BayKkZab3uXw7HyOK1FsLscn/ Ewm33ntab8DXVL8mZK9f+QVSL2Th2Dh8yNUFaxBq7lJLPay60e7Oh6XcUL8u2qQYOGpY 70xSN9+getGycB0hXZrHjdlmAsreEEZg5wWgdShE3d8k/F//vFYVplgLtA74MQZ42LI+ G9jQ== X-Gm-Message-State: AJIora+bhd0d/torKEXUewlGI99DMwkCNmWKHefAfNy4DUJWhnbsDK70 ujUANJF38B18B7skUeyj60BOtbD1M3qgnV+EtbxNjQ== X-Google-Smtp-Source: AGRyM1sSAqvMx+0ORQYHC+kWiR2XZFBAlJ1EmdoGnAa/0iwRNyIrGUH5koEkoCAc7cvHJBODOLxTNoFKHmP3ILtn6x8= X-Received: by 2002:a05:6402:201:b0:431:665f:11f1 with SMTP id t1-20020a056402020100b00431665f11f1mr56090922edv.378.1657132493907; Wed, 06 Jul 2022 11:34:53 -0700 (PDT) MIME-Version: 1.0 References: <20220518170124.2849497-1-dlatypov@google.com> <20220518170124.2849497-2-dlatypov@google.com> In-Reply-To: <20220518170124.2849497-2-dlatypov@google.com> From: Brendan Higgins Date: Wed, 6 Jul 2022 14:34:42 -0400 Message-ID: Subject: Re: [PATCH 1/3] Documentation: kunit: fix example run_kunit func to allow spaces in args To: Daniel Latypov Cc: davidgow@google.com, elver@google.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 1:01 PM Daniel Latypov wrote: > > Without the quoting, the example will mess up invocations like > $ run_kunit "Something with spaces" > > Note: this example isn't valid, but if ever a usecase arises where a > flag argument might have spaces in it, it'll break. > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins