From: Brendan Higgins <brendanhiggins@google.com>
To: Kees Cook <keescook@chromium.org>
Cc: shuah@kernel.org, davidgow@google.com, arnd@arndb.de,
rafael@kernel.org, jic23@kernel.org, lars@metafoo.de,
ulf.hansson@linaro.org, andreas.noever@gmail.com,
michael.jamet@intel.com, mika.westerberg@linux.intel.com,
yehezkelshb@gmail.com, masahiroy@kernel.org,
michal.lkml@markovi.net, ndesaulniers@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v1 1/6] gcc-plugins/structleak: add makefile var for disabling structleak
Date: Wed, 29 Sep 2021 13:25:07 -0700 [thread overview]
Message-ID: <CAFd5g47YMnMzR+dtSLy9NvMb4TkeDkbSNt3qs-kvfLo_0y9-eg@mail.gmail.com> (raw)
In-Reply-To: <202109170808.629688A460@keescook>
On Fri, Sep 17, 2021 at 8:48 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Thu, Sep 16, 2021 at 11:10:59PM -0700, Brendan Higgins wrote:
> > KUnit and structleak don't play nice, so add a makefile variable for
> > enabling structleak when it complains.
> >
> > Co-developed-by: Kees Cook <keescook@chromium.org>
>
> For a C-d-b, also include a S-o-b:
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> But otherwise, yes, this is good. :)
Yeah, I know that's necessary for the patch to be accepted, but in
this case, I don't think your original version of this (it wasn't
actually a patch) had a S-o-b on it, so I didn't want to say that you
had signed off on something that you didn't.
I have run into this situation before and handled it this way -
letting the co-developer sign off on the list. Is this something I
should avoid in the future?
In any case, I will resubmit this now that I have your S-o-b.
Thanks!
next prev parent reply other threads:[~2021-09-29 20:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 6:10 [PATCH v1 0/6] kunit: build kunit tests without structleak plugin Brendan Higgins
2021-09-17 6:10 ` [PATCH v1 1/6] gcc-plugins/structleak: add makefile var for disabling structleak Brendan Higgins
2021-09-17 15:48 ` Kees Cook
2021-09-29 20:25 ` Brendan Higgins [this message]
2021-09-17 6:11 ` [PATCH v1 2/6] iio/test-format: build kunit tests without structleak plugin Brendan Higgins
2021-09-17 15:54 ` Kees Cook
2021-09-29 20:50 ` Brendan Higgins
2021-09-18 15:58 ` Jonathan Cameron
2021-09-17 6:11 ` [PATCH v1 3/6] device property: " Brendan Higgins
2021-09-17 15:54 ` Kees Cook
2021-09-17 6:11 ` [PATCH v1 4/6] thunderbolt: " Brendan Higgins
2021-09-17 10:16 ` Mika Westerberg
2021-09-17 15:55 ` Kees Cook
2021-09-17 6:11 ` [PATCH v1 5/6] mmc: sdhci-of-aspeed: " Brendan Higgins
2021-09-17 15:56 ` Kees Cook
2021-09-17 18:40 ` Linus Torvalds
2021-09-29 20:59 ` Brendan Higgins
2021-09-17 6:11 ` [PATCH v1 6/6] bitfield: " Brendan Higgins
2021-09-17 7:22 ` Arnd Bergmann
2021-09-17 15:57 ` Kees Cook
2021-09-29 21:04 ` Brendan Higgins
2021-09-17 7:38 ` [PATCH v1 0/6] kunit: " Arnd Bergmann
2021-09-29 20:46 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g47YMnMzR+dtSLy9NvMb4TkeDkbSNt3qs-kvfLo_0y9-eg@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=andreas.noever@gmail.com \
--cc=arnd@arndb.de \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michael.jamet@intel.com \
--cc=michal.lkml@markovi.net \
--cc=mika.westerberg@linux.intel.com \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).