From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 339C6C433B4 for ; Tue, 18 May 2021 21:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 080ED611BF for ; Tue, 18 May 2021 21:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242341AbhERVQg (ORCPT ); Tue, 18 May 2021 17:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235250AbhERVQf (ORCPT ); Tue, 18 May 2021 17:16:35 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B689C061573 for ; Tue, 18 May 2021 14:15:17 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id i6so992345plt.4 for ; Tue, 18 May 2021 14:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C43/i5T89+Z7YHAazX11QPS1qt3iN5sh35aKnQ1xBXc=; b=L3SbeGKHfRXdqFWSY/DjtKEhkdISuPfaf1/glYzvtU6a0s3YUDaXW/V2vSONOb9az5 ar6USRpYYzyUHUvBCVpIXy01hUckq3toF9CEzNTqevyNlVn0oaKwy04ztEZY9s9KVohr c+L2SCmGjU987rGITNpj8OFctyth8m4DBrzM3AjVvqKnRJPj2ePJv+ZquXgm75JlYm4s xYwZ0mmw3xwdp9IRqnb/g9tzuw3sTUp3KaPMDh8Yr02zbRwiXCDLS4ztVL9K85hvh+b5 sgBK4fQ1EYBraCdirQ1/Cag9AIQBaI4q1QZ3yzlJnPRibfQ1zVbGu/aRSkArBtdmT2v4 xsWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C43/i5T89+Z7YHAazX11QPS1qt3iN5sh35aKnQ1xBXc=; b=Am5rCyexYEMUWVD6+TIhyw8405XVFLcT5ECa8LGMTxZN24hm8L+6DSUic/0yAhWVvD ZgRfZ1/zoWgCr7l6CJP5L8n212qz4SpSVEI4OBXyM+zW3TuOHFfJOieOwzDSmf3jDjXa UuK9jhgyp59bZNINBWUVkiQMPKV5rlFMMODfe8IBEwZWeYRWjaXpkBSZWvN9xPxVcxeV 1/wH0t3HXvMGd4cBnu1TUEIsMelE7IDlkMyl/GyMnsinUeuBLCITVWL5M5BbAC646D1c IE/kibPFvevDaaULKGzfG6S6/foVtTQfYceU1ULr9dBSVZZO8yyMWNA3SLfmcIWh2SS8 Fvdg== X-Gm-Message-State: AOAM530kXUP/xYoEEwdC3GMNcL2hv2PT6jl3UwrW7jnIg6u96Gxr+07u IJlTxaoM/h0lfIRrqgWJjMDNI0XOOuCxbUvJLjlQPA== X-Google-Smtp-Source: ABdhPJyoobLYnIWbWswtFV+hnCncsmdZCqoP03K67oJ14BVc7qPq4WxTKk04oRtwVQhRoxIz0t3Q99bKTrl82//++vs= X-Received: by 2002:a17:90a:7306:: with SMTP id m6mr7191995pjk.217.1621372516465; Tue, 18 May 2021 14:15:16 -0700 (PDT) MIME-Version: 1.0 References: <20210518035825.1885357-1-davidgow@google.com> In-Reply-To: <20210518035825.1885357-1-davidgow@google.com> From: Brendan Higgins Date: Tue, 18 May 2021 14:15:05 -0700 Message-ID: Subject: Re: [PATCH] kunit: arch/um/configs: Enable KUNIT_ALL_TESTS by default To: David Gow Cc: Shuah Khan , Jeff Dike , Richard Weinberger , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , linux-um , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 8:58 PM David Gow wrote: > > Make the default .kunitconfig (specified in > arch/um/configs/kunit_defconfig) specify CONFIG_KUNIT_ALL_TESTS by > default. KUNIT_ALL_TESTS runs all tests which have satisfied > dependencies in the current .config (which would be the architecture > defconfig). > > Currently, the default .kunitconfig enables only the example tests and > KUnit's own tests. While this does provide a good example of what a > .kunitconfig for running a few individual tests should look like, it > does mean that kunit_tool runs a pretty paltry collection of tests by > default. > > A default run of ./tools/testing/kunit/kunit.py run now runs 70 tests > instead of 14. > > Signed-off-by: David Gow I am totally on board with what you want to do here, but I have one minor issue below. Reviewed-by: Brendan Higgins > --- > arch/um/configs/kunit_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > index 9235b7d42d38..becf3432a375 100644 > --- a/arch/um/configs/kunit_defconfig > +++ b/arch/um/configs/kunit_defconfig Could we also apply this to tools/testing/kunit/configs/all_tests.config ? The contents of the file are identical, and I think are supposed to be for the same purpose. > @@ -1,3 +1,2 @@ > CONFIG_KUNIT=y > -CONFIG_KUNIT_TEST=y > -CONFIG_KUNIT_EXAMPLE_TEST=y > +CONFIG_KUNIT_ALL_TESTS=y > -- > 2.31.1.751.gd2f1c929bd-goog >