archive mirror
 help / color / mirror / Atom feed
From: Brendan Higgins <>
To: "André Almeida" <>
Cc: Christoph Hellwig <>,
	Andy Shevchenko <>,,,, Shuah Khan <>,
	Vitor Massaru Iha <>,, David Gow <>,
	Daniel Latypov <>,
Subject: Re: [PATCH v5 1/1] lib: Convert UUID runtime test to KUnit
Date: Wed, 21 Jul 2021 12:52:52 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Jul 17, 2021 at 4:48 PM André Almeida <> wrote:
> Remove custom functions for testing and use KUnit framework. Keep the
> tested functions and test data the same.
> Current test threat (g/u)uid_parse and (g/u)uid_equal as different test
> cases. Make both functions being part of the same test case, given the
> dependency regarding their results. This reduces the tests cases from 6
> cases to 4, while keeping the test coverage the same. Given that we have
> 3 strings for each test case, current test output notifies 18 tests
> results, and the KUnit output announces 12 results.
> Signed-off-by: André Almeida <>
> Reviewed-by: Daniel Latypov <>

I don't think I have anything to add that hasn't already been said.
Nevertheless, this looks good to me.

Reviewed-by: Brendan Higgins <>

      reply	other threads:[~2021-07-21 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17 23:47 [PATCH v5 0/1] lib: Convert UUID runtime test to KUnit André Almeida
2021-07-17 23:47 ` [PATCH v5 1/1] " André Almeida
2021-07-21 19:52   ` Brendan Higgins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --cc=~lkcamp/ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).