From: Brendan Higgins <brendanhiggins@google.com>
To: "André Almeida" <andrealmeid@collabora.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, Shuah Khan <shuah@kernel.org>,
~lkcamp/patches@lists.sr.ht, nfraprado@collabora.com,
leandro.ribeiro@collabora.com,
Vitor Massaru Iha <vitor@massaru.org>,
lucmaga@gmail.com, David Gow <davidgow@google.com>,
Daniel Latypov <dlatypov@google.com>,
tales.aparecida@gmail.com
Subject: Re: [PATCH v5 1/1] lib: Convert UUID runtime test to KUnit
Date: Wed, 21 Jul 2021 12:52:52 -0700 [thread overview]
Message-ID: <CAFd5g47nOfQ506ZyivLy2U1FkrnNhuDxUr0wUyN=F700mw+N8A@mail.gmail.com> (raw)
In-Reply-To: <20210717234758.46598-2-andrealmeid@collabora.com>
On Sat, Jul 17, 2021 at 4:48 PM André Almeida <andrealmeid@collabora.com> wrote:
>
> Remove custom functions for testing and use KUnit framework. Keep the
> tested functions and test data the same.
>
> Current test threat (g/u)uid_parse and (g/u)uid_equal as different test
> cases. Make both functions being part of the same test case, given the
> dependency regarding their results. This reduces the tests cases from 6
> cases to 4, while keeping the test coverage the same. Given that we have
> 3 strings for each test case, current test output notifies 18 tests
> results, and the KUnit output announces 12 results.
>
> Signed-off-by: André Almeida <andrealmeid@collabora.com>
> Reviewed-by: Daniel Latypov <dlatypov@google.com>
I don't think I have anything to add that hasn't already been said.
Nevertheless, this looks good to me.
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
prev parent reply other threads:[~2021-07-21 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 23:47 [PATCH v5 0/1] lib: Convert UUID runtime test to KUnit André Almeida
2021-07-17 23:47 ` [PATCH v5 1/1] " André Almeida
2021-07-21 19:52 ` Brendan Higgins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g47nOfQ506ZyivLy2U1FkrnNhuDxUr0wUyN=F700mw+N8A@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=andrealmeid@collabora.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=hch@lst.de \
--cc=kunit-dev@googlegroups.com \
--cc=leandro.ribeiro@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucmaga@gmail.com \
--cc=nfraprado@collabora.com \
--cc=shuah@kernel.org \
--cc=tales.aparecida@gmail.com \
--cc=vitor@massaru.org \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).