From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D47C6377A for ; Wed, 21 Jul 2021 19:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 259F161208 for ; Wed, 21 Jul 2021 19:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239925AbhGUTMd (ORCPT ); Wed, 21 Jul 2021 15:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239730AbhGUTM2 (ORCPT ); Wed, 21 Jul 2021 15:12:28 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F4C7C061757 for ; Wed, 21 Jul 2021 12:53:04 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id j1so800988pjj.4 for ; Wed, 21 Jul 2021 12:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NRbb2WhKrno0rg5XVu8dJTfW7QbPPoDT9nWYWG2fU04=; b=Zzrk729wAqGilC6KYU+4BZArciy7pZDSM7C98suRTP+rY1Alunx9WnXRn1ijGDQ4qr ORSJ7IVuNgMtRsVkn04q55/yvSTa7X01QoLAWnpIJpg8dfg+lE5QCkLBhIqXTRXv+BtA SzPMcvWsnCsHNt0YZrk+Q93X7z49RBVnGOY2fkMVZvRxdfdOX2k5fPDoIqkq8xYagxjI C54roWj4UlWVOXdGMYAsZXKG+PxU7cJqVYKu11pJ6mUyB4M9xQXYjz0Gc1lp38PBUhtq ZRR8g4ICOc1Eb6j+hzuFH8Dww/4DhZHjQ4RriyZHvAnQLpcc0nrO//XZ/pxl0g7D4sic U7oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NRbb2WhKrno0rg5XVu8dJTfW7QbPPoDT9nWYWG2fU04=; b=jNyORW1HMLRUT4rgQLVJRfjYM3CpC/LlkZpqQCRvYoJTIN6pt7MlUEY5HqAzodKX9S ExhufYhi9xcvv32rAved/fHrQ0DFUVXHUb6zbi/0QYKeO3ByTEL/2+2OQQsEs1ntVXnt 7ykU1lLm70y/0wdJr+Ui7x/E8HoIg/bK09EM2qW47rbzPN8T2Gv3AKOuUHerNTJP0X0Y vJwdEs136HFJI8T3gK4MZZhYLTdPkvHWWI43Xnx9LChHAoL4vc91oerCTI0u5kcrNYpP pPEaPkBklrTxP/Tq0jZfOrS9GH24zxeBO06mP4fRp4Atvp+i23d2Mip3He6s4LE09zPi w2dw== X-Gm-Message-State: AOAM532Kg+1V/uya2g5lbTDpNnvFQXZIAnkt9oxCFpogO8ZqrBjHnq1B Ba5kHFen/POz99p4+OThUyk4whMC+TW3bTvdTGhSZkYsaiXJhA== X-Google-Smtp-Source: ABdhPJzH4d3B0PuFlBwcr6uSCwfZe56uh2y9B0upxapM08pQm8+CliBNhuJMlpm2Fa1l2Iaihfu25JZva1y+Y9BG7ng= X-Received: by 2002:a65:6a01:: with SMTP id m1mr38108609pgu.201.1626897183577; Wed, 21 Jul 2021 12:53:03 -0700 (PDT) MIME-Version: 1.0 References: <20210717234758.46598-1-andrealmeid@collabora.com> <20210717234758.46598-2-andrealmeid@collabora.com> In-Reply-To: <20210717234758.46598-2-andrealmeid@collabora.com> From: Brendan Higgins Date: Wed, 21 Jul 2021 12:52:52 -0700 Message-ID: Subject: Re: [PATCH v5 1/1] lib: Convert UUID runtime test to KUnit To: =?UTF-8?Q?Andr=C3=A9_Almeida?= Cc: Christoph Hellwig , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Shuah Khan , ~lkcamp/patches@lists.sr.ht, nfraprado@collabora.com, leandro.ribeiro@collabora.com, Vitor Massaru Iha , lucmaga@gmail.com, David Gow , Daniel Latypov , tales.aparecida@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 4:48 PM Andr=C3=A9 Almeida wrote: > > Remove custom functions for testing and use KUnit framework. Keep the > tested functions and test data the same. > > Current test threat (g/u)uid_parse and (g/u)uid_equal as different test > cases. Make both functions being part of the same test case, given the > dependency regarding their results. This reduces the tests cases from 6 > cases to 4, while keeping the test coverage the same. Given that we have > 3 strings for each test case, current test output notifies 18 tests > results, and the KUnit output announces 12 results. > > Signed-off-by: Andr=C3=A9 Almeida > Reviewed-by: Daniel Latypov I don't think I have anything to add that hasn't already been said. Nevertheless, this looks good to me. Reviewed-by: Brendan Higgins