From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD64C433FE for ; Thu, 12 May 2022 19:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357840AbiELTBg (ORCPT ); Thu, 12 May 2022 15:01:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355699AbiELTBf (ORCPT ); Thu, 12 May 2022 15:01:35 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757E84C406 for ; Thu, 12 May 2022 12:01:34 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id i19so12010956eja.11 for ; Thu, 12 May 2022 12:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pszSDfe0UbNgZW4RxKcUIgfomIDDQRx5VP5T7VUEGIM=; b=VQA5v8vqLahAK/ejzfmgUBIfDmleeuUyWizNuLo7eork68u0Kdo0mLk2LagPzvdFwu bPCS9pMREZcOLfpyQDK34HFBotdepKvHzCsAOrES5gBMNoFMkdTjhNWo3ROXCx8UIc6v BCV6hXpLKsRMRyhsT3mtXAL6JctiOwVyu0Mtk+yNpYb9O3TLaydg6GrpNp6If5JZq/2u rssY3r/WK4mSLTJQ7j7QHbvFf/6tkQnm06XpMa68d3wW/OykknmCFx3ve/RcoC7VmZQo aMmeuLlc6VWJC+vLFjNH6JHeTvcDMOyWHEaZB5+wgl5AgyD4B4DGg2VFzVrGtKgI1+lS OgMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pszSDfe0UbNgZW4RxKcUIgfomIDDQRx5VP5T7VUEGIM=; b=LjdLwU/m2TLA3KQ5gPNP1QJmu1Ginau3R9zK4iUDZNyiKeOkbvqNDwQqN/qWUzDF2k 1BLQNFzqkJOVIWC+6S14XY/qNkXmdOyHc7Sg7AouCWF3Eiju80inP9HofxQ38j9XvhSF WQt9xlLt+b6xe9xbTfwJJl4SzmZ1FcRmxg9e6Plsn5i1aoxyEoCyBGxLiMEJckpELBZT ofkQ6i08CDMSZb/1RQ1zE229PfjekXfvVjDPU2bkDSX+rEg7eL/eQ+EXkbXwed+7tHoX /sBOB9v46z2j2xMm6vGvWT2+8wCYmdNFEfR0x4pgb1pSpi1ovBPuLp3Vy0d0gHltAWRs O6DA== X-Gm-Message-State: AOAM530vJQeH6nW0Uhu2hAINqPmMSpeicn1i5Ex9DEont13dboG2KfW4 Bfg68ajsft3bO9i/Q+Ad4T0ZaKMX2CQT8OscXGWzN+dUoqw2GuDP X-Google-Smtp-Source: ABdhPJwemMtr42pU2bJn8Gbt0kVxmOlvLYjum2OQe6Gv6T1/qdj76xgaaBMFoVVLZwHNnlZ+i3CiOANGsUxi8Hhu0qQ= X-Received: by 2002:a17:907:8a24:b0:6f4:82c9:9adc with SMTP id sc36-20020a1709078a2400b006f482c99adcmr1202252ejc.223.1652382092846; Thu, 12 May 2022 12:01:32 -0700 (PDT) MIME-Version: 1.0 References: <20220507052451.12890-1-ojeda@kernel.org> <20220507052451.12890-5-ojeda@kernel.org> In-Reply-To: <20220507052451.12890-5-ojeda@kernel.org> From: Brendan Higgins Date: Thu, 12 May 2022 15:01:21 -0400 Message-ID: Subject: Re: [PATCH v6 04/23] kunit: take `kunit_assert` as `const` To: Miguel Ojeda Cc: Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jarkko Sakkinen , Daniel Latypov , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 7, 2022 at 1:26 AM Miguel Ojeda wrote: > > The `kunit_do_failed_assertion` function passes its > `struct kunit_assert` argument to `kunit_fail`. This one, > in turn, calls its `format` field passing the assert again > as a `const` pointer. > > Therefore, the whole chain may be made `const`. > > Reviewed-by: Daniel Latypov > Signed-off-by: Miguel Ojeda Reviewed-by: Brendan Higgins