From: Pingfan Liu <kernelfans@gmail.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: jnwang@suse.com, tiwai@suse.de, bp@suse.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] Errors at reboot after 722e5f2b1eec
Date: Fri, 14 Sep 2018 10:29:46 +0800 [thread overview]
Message-ID: <CAFgQCTuNb4XOg6LaY=m92zbhDTNmYkh11Dxy4OGbXtY09oXb9A@mail.gmail.com> (raw)
In-Reply-To: <2551848.SakgYeHO72@aspire.rjw.lan>
On Thu, Sep 13, 2018 at 10:15 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Thursday, September 13, 2018 12:03:36 PM CEST James Wang wrote:
> > This is a multi-part message in MIME format.
> > --------------F5519E624D0AD1E3F7DDA019
> > Content-Type: text/plain; charset=utf-8
> > Content-Transfer-Encoding: 8bit
> >
> >
> >
> > On 09/11/2018 02:15 PM, Takashi Iwai wrote:
> > > On Tue, 11 Sep 2018 14:11:30 +0200,
> > > James Wang wrote:
> > >> I did try it from kernel : head
> > > OK, then the bug is present with 4.19-rc2, at least.
> > > Please check my test kernel later (it's still being built).
> > Hi folks, I attach two log about 4.19-rc3 and 4.19-rc3+Rafeal suggestion.
>
> OK, no difference AFAICS.
>
> This means that the commit turned up by bisection simply uncovered an existing
> ordering issue, apparently between an IOMMU and its client (ie. it appears that
> the client is shut down after the IOMMU).
>
> This isn't limited to shutdown and you'd see the same issue on system-wide
> suspend/resume (in fact, the Pingfan Liu's patches make shutdown use the
> same device list that is used for system-wide PM).
>
> One way to mitigate such issues is to add a device link between the two
> devices in question to enforce the correct suspend/resume/shutdown ordering
> between them.
>
I found the iommu was at " 0000:00:00.2", while ohci-pci is at
0000:00:13.1. Hence ohci-pci should be shutdown before iommu. Not
familiar with AMD's iommu code, but I think there is no shutdown
interface exported to drivers/base. It is shutdown by platform code in
arch/x86. So I think there should be someone teared down the iotbl,
e.g. by invalidating pages, before the shutdown of ohci-pci. I wonder
whether adding a device link can fix this bug or not. (Forgive me if I
made a mistake, since I am ignorant in this field)
Thanks,
Pingfan
next prev parent reply other threads:[~2018-09-14 2:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s5hk1ns1m8n.wl-tiwai@suse.de>
2018-09-11 9:33 ` [REGRESSION] Errors at reboot after 722e5f2b1eec Greg Kroah-Hartman
2018-09-11 10:51 ` Rafael J. Wysocki
2018-09-11 11:01 ` Borislav Petkov
2018-09-11 11:55 ` Takashi Iwai
2018-09-11 12:26 ` James Wang
[not found] ` <441b2b19-1a73-4cde-913d-61a9f8072f08@suse.com>
2018-09-11 12:15 ` Takashi Iwai
2018-09-13 10:03 ` James Wang
2018-09-13 14:13 ` Rafael J. Wysocki
2018-09-14 2:29 ` Pingfan Liu [this message]
2018-09-14 6:26 ` Rafael J. Wysocki
2018-09-14 7:14 ` Borislav Petkov
2018-09-12 6:41 ` Pingfan Liu
2018-09-12 9:10 ` James Wang
2018-09-12 9:56 ` Rafael J. Wysocki
2018-09-13 15:21 ` James Wang
2018-09-13 20:50 ` Rafael J. Wysocki
2018-09-14 6:23 ` James Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFgQCTuNb4XOg6LaY=m92zbhDTNmYkh11Dxy4OGbXtY09oXb9A@mail.gmail.com' \
--to=kernelfans@gmail.com \
--cc=bp@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jnwang@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).