* [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown()
@ 2019-05-24 2:15 Ley Foon Tan
2019-05-24 2:17 ` Ley Foon Tan
0 siblings, 1 reply; 3+ messages in thread
From: Ley Foon Tan @ 2019-05-24 2:15 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi
Cc: linux-kernel, linux-pci, lftan.linux, Ley Foon Tan
Fix compilation warning caused by patch "PCI: altera: Allow building as module".
drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
drivers/pci/controller/pcie-altera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
index 6c86bc69ace8..27222071ace7 100644
--- a/drivers/pci/controller/pcie-altera.c
+++ b/drivers/pci/controller/pcie-altera.c
@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
return 0;
}
-static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
+static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
{
irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
irq_domain_remove(pcie->irq_domain);
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown()
2019-05-24 2:15 [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown() Ley Foon Tan
@ 2019-05-24 2:17 ` Ley Foon Tan
2019-05-30 14:54 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Ley Foon Tan @ 2019-05-24 2:17 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: Bjorn Helgaas, Lorenzo Pieralisi, linux-kernel, linux-pci
On Fri, May 24, 2019 at 10:15 AM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>
> Fix compilation warning caused by patch "PCI: altera: Allow building as module".
>
> drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
> drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
> }
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> drivers/pci/controller/pcie-altera.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> index 6c86bc69ace8..27222071ace7 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
> return 0;
> }
>
> -static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
> +static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
> {
> irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
> irq_domain_remove(pcie->irq_domain);
> --
> 2.19.0
>
Hi
You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
"PCI: altera: Allow building as module" if want.
Thanks.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown()
2019-05-24 2:17 ` Ley Foon Tan
@ 2019-05-30 14:54 ` Lorenzo Pieralisi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-05-30 14:54 UTC (permalink / raw)
To: Ley Foon Tan; +Cc: Ley Foon Tan, Bjorn Helgaas, linux-kernel, linux-pci
On Fri, May 24, 2019 at 10:17:28AM +0800, Ley Foon Tan wrote:
> On Fri, May 24, 2019 at 10:15 AM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> >
> > Fix compilation warning caused by patch "PCI: altera: Allow building as module".
> >
> > drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
> > drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
> > }
> >
> > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> > ---
> > drivers/pci/controller/pcie-altera.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> > index 6c86bc69ace8..27222071ace7 100644
> > --- a/drivers/pci/controller/pcie-altera.c
> > +++ b/drivers/pci/controller/pcie-altera.c
> > @@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
> > return 0;
> > }
> >
> > -static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
> > +static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
> > {
> > irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
> > irq_domain_remove(pcie->irq_domain);
> > --
> > 2.19.0
> >
> Hi
>
> You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
> "PCI: altera: Allow building as module" if want.
Done, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-30 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 2:15 [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown() Ley Foon Tan
2019-05-24 2:17 ` Ley Foon Tan
2019-05-30 14:54 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).