From: Ming Lei <ming.lei@redhat.com>
To: Chris Murphy <lists@colorremedies.com>
Cc: Nikolay Borisov <nborisov@suse.com>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>, Paolo Valente <paolo.valente@linaro.org>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
Linux-RAID <linux-raid@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: stalling IO regression since linux 5.12, through 5.18
Date: Thu, 18 Aug 2022 23:10:13 +0800 [thread overview]
Message-ID: <CAFj5m9JGGMOc1k71KbiHWu07Vh5FucOtR_yU35eDAfX_2GL0TQ@mail.gmail.com> (raw)
In-Reply-To: <aadeb600-4e3a-4b69-bc17-fd2918c5b061@www.fastmail.com>
On Thu, Aug 18, 2022 at 9:50 PM Chris Murphy <lists@colorremedies.com> wrote:
>
>
>
> On Thu, Aug 18, 2022, at 1:24 AM, Ming Lei wrote:
>
> >
> > Also please test the following one too:
> >
> >
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 5ee62b95f3e5..d01c64be08e2 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1991,7 +1991,8 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx
> > *hctx, struct list_head *list,
> > if (!needs_restart ||
> > (no_tag && list_empty_careful(&hctx->dispatch_wait.entry)))
> > blk_mq_run_hw_queue(hctx, true);
> > - else if (needs_restart && needs_resource)
> > + else if (needs_restart && (needs_resource ||
> > + blk_mq_is_shared_tags(hctx->flags)))
> > blk_mq_delay_run_hw_queue(hctx, BLK_MQ_RESOURCE_DELAY);
> >
> > blk_mq_update_dispatch_busy(hctx, true);
> >
>
> Should I test both patches at the same time, or separately? On top of v5.17 clean, or with b6e68ee82585 still reverted?
Please test it separately against v5.17.
thanks,
next prev parent reply other threads:[~2022-08-18 15:10 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 16:35 stalling IO regression in linux 5.12 Chris Murphy
2022-08-10 17:48 ` Josef Bacik
2022-08-10 18:33 ` Chris Murphy
2022-08-10 18:42 ` Chris Murphy
2022-08-10 19:31 ` Josef Bacik
2022-08-10 19:34 ` Chris Murphy
2022-08-12 16:05 ` stalling IO regression since linux 5.12, through 5.18 Chris Murphy
2022-08-12 17:59 ` Josef Bacik
2022-08-12 18:02 ` Jens Axboe
2022-08-14 20:28 ` Chris Murphy
2022-08-16 14:22 ` Chris Murphy
2022-08-16 15:25 ` Nikolay Borisov
2022-08-16 15:34 ` Chris Murphy
2022-08-17 9:52 ` Holger Hoffstätte
2022-08-17 11:49 ` Jan Kara
2022-08-17 14:37 ` Chris Murphy
2022-08-17 15:09 ` Chris Murphy
2022-08-17 16:30 ` Jan Kara
2022-08-17 16:47 ` Chris Murphy
2022-08-17 17:57 ` Chris Murphy
2022-08-17 18:15 ` Jan Kara
2022-08-17 18:18 ` Chris Murphy
2022-08-17 18:33 ` Jan Kara
2022-08-17 18:54 ` Chris Murphy
2022-08-17 19:23 ` Chris Murphy
2022-08-18 2:31 ` Chris Murphy
2022-08-17 18:21 ` Holger Hoffstätte
2022-08-17 11:57 ` Chris Murphy
2022-08-17 12:31 ` Holger Hoffstätte
2022-08-17 18:16 ` Chris Murphy
2022-08-17 18:38 ` Holger Hoffstätte
2022-08-17 12:06 ` Ming Lei
2022-08-17 14:34 ` Chris Murphy
2022-08-17 14:53 ` Ming Lei
2022-08-17 15:02 ` Chris Murphy
2022-08-17 15:34 ` Ming Lei
2022-08-17 16:34 ` Chris Murphy
2022-08-18 1:03 ` Ming Lei
2022-08-18 2:30 ` Chris Murphy
2022-08-18 3:24 ` Ming Lei
2022-08-18 4:12 ` Chris Murphy
2022-08-18 4:18 ` Chris Murphy
2022-08-18 4:27 ` Chris Murphy
2022-08-18 4:32 ` Chris Murphy
2022-08-18 5:15 ` Ming Lei
2022-08-18 18:52 ` Chris Murphy
2022-08-18 5:24 ` Ming Lei
2022-08-18 13:50 ` Chris Murphy
2022-08-18 15:10 ` Ming Lei [this message]
2022-08-19 19:20 ` Chris Murphy
2022-08-20 7:00 ` Ming Lei
2022-09-01 7:02 ` Yu Kuai
2022-09-01 8:03 ` Jan Kara
2022-09-01 8:19 ` Yu Kuai
2022-09-06 9:49 ` Paolo Valente
2022-09-02 16:53 ` Chris Murphy
2022-09-06 9:45 ` Paolo Valente
2022-08-15 11:25 ` stalling IO regression in linux 5.12 Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFj5m9JGGMOc1k71KbiHWu07Vh5FucOtR_yU35eDAfX_2GL0TQ@mail.gmail.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=nborisov@suse.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).