Re: [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()

From: Nitesh Lal <nilal@redhat.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, jassisinghbrar@gmail.com,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Tushar.Khandelwal@arm.com, manivannan.sadhasivam@linaro.org,
	lewis.hanly@microchip.com, ley.foon.tan@intel.com,
	kabel@kernel.org, huangguangbin2@huawei.com, davem@davemloft.net,
	benve@cisco.com, govind@gmx.com, kashyap.desai@broadcom.com,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	shivasharan.srikanteshwara@broadcom.com,
	sathya.prakash@broadcom.com,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	suganath-prabu.subramani@broadcom.com,
	ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
	somnath.kotur@broadcom.com, linux-pci@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	rostedt@goodmis.org, Marc Zyngier <maz@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	jbrandeb@kernel.org, Frederic Weisbecker <frederic@kernel.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Alex Belits <abelits@marvell.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	akpm@linuxfoundation.org, sfr@canb.auug.org.au,
	stephen@networkplumber.org, rppt@linux.vnet.ibm.com,
	chris.friesen@windriver.com, Neil Horman <nhorman@tuxdriver.com>,
	pjwaskiewicz@gmail.com, Stefan Assmann <sassmann@redhat.com>,
	Tomas Henzl <thenzl@redhat.com>,
	james.smart@broadcom.com,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Ken Cox <jkc@redhat.com>,
	faisal.latif@intel.com, shiraz.saleem@intel.com,
	tariqt@nvidia.com, Alaa Hleihel <ahleihel@redhat.com>,
	Kamal Heib <kheib@redhat.com>,
	borisp@nvidia.com, saeedm@nvidia.com,
	Nitesh Lal <nilal@redhat.com>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
	"Ismail, Mustafa" <mustafa.ismail@intel.com>,
	Al Stone <ahs3@redhat.com>, Leon Romanovsky <leonro@nvidia.com>,
	Chandrakanth Patil <chandrakanth.patil@broadcom.com>,
	bjorn.andersson@linaro.org, chunkuang.hu@kernel.org,
	yongqiang.niu@mediatek.com, baolin.wang7@gmail.com,
	Petr Oros <poros@redhat.com>, Ming Lei <minlei@redhat.com>,
	Ewan Milne <emilne@redhat.com>,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
Date: Mon, 2 Aug 2021 11:26:39 -0400	[thread overview]
Message-ID: <CAFki+LkNzk0ajUeuBnJZ6mp1kxB0+zZf60tw1Vfq+nPy-bvftQ@mail.gmail.com> (raw)
In-Reply-To: <20210720232624.1493424-1-nitesh@redhat.com>

On Tue, Jul 20, 2021 at 7:26 PM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
>
> The drivers currently rely on irq_set_affinity_hint() to either set the
> affinity_hint that is consumed by the userspace and/or to enforce a custom
> affinity.
>
> irq_set_affinity_hint() as the name suggests is originally introduced to
> only set the affinity_hint to help the userspace in guiding the interrupts
> and not the affinity itself. However, since the commit
>
>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
>

[...]

>  drivers/infiniband/hw/irdma/hw.c              |  4 +-
>  drivers/mailbox/bcm-flexrm-mailbox.c          |  4 +-
>  drivers/net/ethernet/cisco/enic/enic_main.c   |  8 +--
>  drivers/net/ethernet/emulex/benet/be_main.c   |  4 +-
>  drivers/net/ethernet/huawei/hinic/hinic_rx.c  |  4 +-
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  8 +--
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 +--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++--
>  drivers/net/ethernet/mellanox/mlx4/eq.c       |  8 ++-
>  .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  8 +--
>  drivers/scsi/lpfc/lpfc_init.c                 |  4 +-
>  drivers/scsi/megaraid/megaraid_sas_base.c     | 27 +++++-----
>  drivers/scsi/mpt3sas/mpt3sas_base.c           | 21 ++++----
>  include/linux/interrupt.h                     | 53 ++++++++++++++++++-
>  kernel/irq/manage.c                           |  8 +--
>  15 files changed, 114 insertions(+), 65 deletions(-)
>
> --
>
>

Gentle ping.
Any comments on the following patches:

  genirq: Provide new interfaces for affinity hints
  scsi: megaraid_sas: Use irq_set_affinity_and_hint
  scsi: mpt3sas: Use irq_set_affinity_and_hint
  enic: Use irq_update_affinity_hint
  be2net: Use irq_update_affinity_hint
  mailbox: Use irq_update_affinity_hint
  hinic: Use irq_set_affinity_and_hint

or any other patches?

-- 
Thanks
Nitesh