From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC68C4743C for ; Mon, 21 Jun 2021 13:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD2CC61156 for ; Mon, 21 Jun 2021 13:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhFUNCS (ORCPT ); Mon, 21 Jun 2021 09:02:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30820 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbhFUNCO (ORCPT ); Mon, 21 Jun 2021 09:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624280399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+YgUj6PMWgTlE2/zJGxRd3Re9nIIH1KzyMdqnBdCris=; b=TDsd6DOqYEmNtglxYYf5Zevq8TZimrqE/Bp4N3nwomCTvBY87wEI2NdU67psyTC333oUVS geXjkjhOo4jcv+KYVwtBCaqMIo0Lj7o9mabdNuQH8/CmuQtAUjmokARmRW8ohcwElRajsT t0AbiSZphGnXF6ISQ/cbiFLql63HVv8= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-2xZo_P6yPrynCIQo5Od4Dg-1; Mon, 21 Jun 2021 08:59:58 -0400 X-MC-Unique: 2xZo_P6yPrynCIQo5Od4Dg-1 Received: by mail-lj1-f197.google.com with SMTP id v3-20020a2e99030000b0290144dc7b6cf0so9200948lji.2 for ; Mon, 21 Jun 2021 05:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+YgUj6PMWgTlE2/zJGxRd3Re9nIIH1KzyMdqnBdCris=; b=fNCcDtUh2z6XKgehNHF61vLUGqKxpsmj33kVIssg9bR9tVUMOnOBqX+egUp5iKfDS1 WawPuNBPE+YaPbkma0oUDWcMYJ3+ERhs2EZekbv3oyGtwjRq42hpL1wnMvJbvbmUefyb UIOcw95gzwOk0duyY9tQdzjlndjMjqA0pop54krwgv8Jn5Zxl+dinad5+IEggm1ftvj/ GvcxaVNLG2ePM2AJMY0YxYS3466Mp2hOAW/zs0IdaGNnnR1VbUSHM5MyPJS/5kmljfcH UUj4hcW7yufFi7kgLnjMg0XwzW74yfyI5630RTE+Yfydxw8woJSFVIV6dvqOn96tIlzo brDA== X-Gm-Message-State: AOAM5311t2KniYfmwDXUaH4tScn/auqb/AiVWX+pn+kEef9+/I5el7p+ ETw6EQHsekJps1D/5NaaBszbkNNq7BQ0dT4gMufUf1mFfqRVud++jlNIVoe0M+z7wKDshcH7dTl cNKnKbXVdqDeripnsKC1Zk6ONdKWABjFVmD/40eMx X-Received: by 2002:a05:651c:211e:: with SMTP id a30mr12543826ljq.14.1624280396487; Mon, 21 Jun 2021 05:59:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgIQ11ykk0gwSlBTwdhqnda7mKHULal69m5BhjOHqEt21B5fLii3Df/yGCCr/pjsOr3FghqA8GvR4oD/ugEpM= X-Received: by 2002:a05:651c:211e:: with SMTP id a30mr12543807ljq.14.1624280396133; Mon, 21 Jun 2021 05:59:56 -0700 (PDT) MIME-Version: 1.0 References: <20210617182242.8637-1-nitesh@redhat.com> <20210617182242.8637-15-nitesh@redhat.com> In-Reply-To: From: Nitesh Lal Date: Mon, 21 Jun 2021 08:59:44 -0400 Message-ID: Subject: Re: [PATCH v1 14/14] net/mlx4: Use irq_update_affinity_hint To: Leon Romanovsky Cc: Nitesh Narayan Lal , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, luobin9@huawei.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 4:02 AM Leon Romanovsky wrote: > > On Thu, Jun 17, 2021 at 02:22:42PM -0400, Nitesh Narayan Lal wrote: > > The driver uses irq_set_affinity_hint() to update the affinity_hint mask > > that is consumed by the userspace to distribute the interrupts. However, > > under the hood irq_set_affinity_hint() also applies the provided cpumask > > (if not NULL) as the affinity for the given interrupt which is an > > undocumented side effect. > > > > To remove this side effect irq_set_affinity_hint() has been marked > > as deprecated and new interfaces have been introduced. Hence, replace the > > irq_set_affinity_hint() with the new interface irq_update_affinity_hint() > > that only updates the affinity_hint pointer. > > > > Signed-off-by: Nitesh Narayan Lal > > --- > > drivers/net/ethernet/mellanox/mlx4/eq.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c > > index 9e48509ed3b2..f549d697ca95 100644 > > --- a/drivers/net/ethernet/mellanox/mlx4/eq.c > > +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c > > @@ -244,9 +244,9 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec) > > cpumask_empty(eq->affinity_mask)) > > return; > > > > - hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask); > > + hint_err = irq_update_affinity_hint(eq->irq, eq->affinity_mask); > > if (hint_err) > > - mlx4_warn(dev, "irq_set_affinity_hint failed, err %d\n", hint_err); > > + mlx4_warn(dev, "irq_update_affinity_hint failed, err %d\n", hint_err); > > } > > #endif > > > > @@ -1124,7 +1124,7 @@ static void mlx4_free_irqs(struct mlx4_dev *dev) > > if (eq_table->eq[i].have_irq) { > > free_cpumask_var(eq_table->eq[i].affinity_mask); > > #if defined(CONFIG_SMP) > > - irq_set_affinity_hint(eq_table->eq[i].irq, NULL); > > + irq_update_affinity_hint(eq_table->eq[i].irq, NULL); > > #endif > > This #if/endif can be deleted. > Ack will get rid of them in v2. > Thanks, > Reviewed-by: Leon Romanovsky > -- Thanks Nitesh