From: Matteo Croce <mcroce@linux.microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled
Date: Thu, 1 Oct 2020 16:19:02 +0200 [thread overview]
Message-ID: <CAFnufp1-rYvVFykL94r-XLCyO7NDFO6UjPVQi-FG2E=iVKh50Q@mail.gmail.com> (raw)
In-Reply-To: <87a6x69hbf.fsf@vitty.brq.redhat.com>
On Thu, Oct 1, 2020 at 4:01 PM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> Matteo Croce <mcroce@linux.microsoft.com> writes:
>
> > From: Matteo Croce <mcroce@microsoft.com>
> >
> > Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
> >
> > Signed-off-by: Matteo Croce <mcroce@microsoft.com>
>
> I'd even say
>
> Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")
>
Indeed, thanks
> > ---
> > arch/x86/kvm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbd5bd7a945a..f92dfd8ef10d 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -66,6 +66,7 @@ config KVM_WERROR
> > default y if X86_64 && !KASAN
> > # We use the dependency on !COMPILE_TEST to not be enabled
> > # blindly in allmodconfig or allyesconfig configurations
> > + depends on KVM
> > depends on (X86_64 && !KASAN) || !COMPILE_TEST
> > depends on EXPERT
> > help
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> --
> Vitaly
>
--
per aspera ad upstream
next prev parent reply other threads:[~2020-10-01 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 11:20 [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled Matteo Croce
2020-10-01 14:00 ` Vitaly Kuznetsov
2020-10-01 14:19 ` Matteo Croce [this message]
2020-10-19 15:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFnufp1-rYvVFykL94r-XLCyO7NDFO6UjPVQi-FG2E=iVKh50Q@mail.gmail.com' \
--to=mcroce@linux.microsoft.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).