Re: [PATCH net-next RFC 0/2] add elevated refcnt support for page pool

From: Matteo Croce <mcroce@linux.microsoft.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Yunsheng Lin <linyunsheng@huawei.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Sven Auhagen <sven.auhagen@voleatech.de>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linuxarm@openeuler.org, yisen.zhuang@huawei.com,
	salil.mehta@huawei.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Will Deacon <will@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Fenghua Yu <fenghua.yu@intel.com>, Roman Gushchin <guro@fb.com>,
	Peter Xu <peterx@redhat.com>,
	feng.tang@intel.com, Jason Gunthorpe <jgg@ziepe.ca>,
	Matteo Croce <mcroce@microsoft.com>,
	Hugh Dickins <hughd@google.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Alexander Lobakin <alobakin@pm.me>,
	Willem de Bruijn <willemb@google.com>, wenxu <wenxu@ucloud.cn>,
	Cong Wang <cong.wang@bytedance.com>,
	Kevin Hao <haokexin@gmail.com>,
	Aleksandr Nogikh <nogikh@google.com>,
	Marco Elver <elver@google.com>,
	netdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCH net-next RFC 0/2] add elevated refcnt support for page pool
Date: Wed, 7 Jul 2021 01:19:37 +0200	[thread overview]
Message-ID: <CAFnufp1hM6WRDigAsSfM94yneRhkmxBoGG7NxRUkbfTR2WQvyA@mail.gmail.com> (raw)
In-Reply-To: <20210706155131.GS22278@shell.armlinux.org.uk>

On Tue, Jul 6, 2021 at 5:51 PM Russell King (Oracle)
<linux@armlinux.org.uk> wrote:
>
> On Fri, Jul 02, 2021 at 03:39:47PM +0200, Matteo Croce wrote:
> > On Wed, 30 Jun 2021 17:17:54 +0800
> > Yunsheng Lin <linyunsheng@huawei.com> wrote:
> >
> > > This patchset adds elevated refcnt support for page pool
> > > and enable skb's page frag recycling based on page pool
> > > in hns3 drvier.
> > >
> > > Yunsheng Lin (2):
> > >   page_pool: add page recycling support based on elevated refcnt
> > >   net: hns3: support skb's frag page recycling based on page pool
> > >
> > >  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c    |  79 +++++++-
> > >  drivers/net/ethernet/hisilicon/hns3/hns3_enet.h    |   3 +
> > >  drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c |   1 +
> > >  drivers/net/ethernet/marvell/mvneta.c              |   6 +-
> > >  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c    |   2 +-
> > >  include/linux/mm_types.h                           |   2 +-
> > >  include/linux/skbuff.h                             |   4 +-
> > >  include/net/page_pool.h                            |  30 ++-
> > >  net/core/page_pool.c                               | 215
> > > +++++++++++++++++---- 9 files changed, 285 insertions(+), 57
> > > deletions(-)
> > >
> >
> > Interesting!
> > Unfortunately I'll not have access to my macchiatobin anytime soon, can
> > someone test the impact, if any, on mvpp2?
>
> I'll try to test. Please let me know what kind of testing you're
> looking for (I haven't been following these patches, sorry.)
>

A drop test or L2 routing will be enough.
BTW I should have the macchiatobin back on friday.

Regards,
-- 
per aspera ad upstream