From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7830C00A89 for ; Fri, 30 Oct 2020 14:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C3E2076E for ; Fri, 30 Oct 2020 14:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="JyYHfDBT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726781AbgJ3OSn (ORCPT ); Fri, 30 Oct 2020 10:18:43 -0400 Received: from linux.microsoft.com ([13.77.154.182]:52246 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbgJ3OSm (ORCPT ); Fri, 30 Oct 2020 10:18:42 -0400 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by linux.microsoft.com (Postfix) with ESMTPSA id D858920B9C34 for ; Fri, 30 Oct 2020 07:18:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D858920B9C34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1604067521; bh=7UykXxKuhXvnD0pPPledPURv1zD8fsOWW1uVdnm6m4c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JyYHfDBTp4HVSAwxv9gSd6JlMT9P6X/4ZnYIt1E5up8xqXhWJpj/gHQa0r36NqVvj NUjVS5DmsytzujpWE+gPvIcrSUWUsmGNlTcDwRNd1tXD59+tdHELbUib051eIRcSGM rrUMBJp2AoHEJ9QRPwtyTADXwcWojlOzfkPmPnwk= Received: by mail-qt1-f177.google.com with SMTP id h12so4137300qtc.9 for ; Fri, 30 Oct 2020 07:18:41 -0700 (PDT) X-Gm-Message-State: AOAM5307vatV4wBCoDLYffxgP3MWvVLrYcTaRqHtApCXwAhh0th4TqbR qg66dSS+BWMfvHuHObR5XbMuxzIc+mLU3Xx66JE= X-Google-Smtp-Source: ABdhPJxf44vFdPqblAg8m63rmdMWM6RRnMj2t589nY8TpfmmG5Bi2apIVDg6uHrfKyRocCvrb9b4TKUbcX3Q6sWZ0XU= X-Received: by 2002:ac8:7408:: with SMTP id p8mr2204569qtq.320.1604067520927; Fri, 30 Oct 2020 07:18:40 -0700 (PDT) MIME-Version: 1.0 References: <20201027133545.58625-1-mcroce@linux.microsoft.com> <20201027133545.58625-2-mcroce@linux.microsoft.com> <20201027134243.GC991306@kroah.com> <20201030141324.GD1602@alley> In-Reply-To: <20201030141324.GD1602@alley> From: Matteo Croce Date: Fri, 30 Oct 2020 15:18:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] reboot: fix overflow parsing reboot cpu number To: Petr Mladek Cc: Greg KH , linux-kernel@vger.kernel.org, Guenter Roeck , Arnd Bergmann , Mike Rapoport , Kees Cook , Pavel Tatashin , Robin Holt , Fabian Frederick Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 3:13 PM Petr Mladek wrote: > > On Tue 2020-10-27 14:42:43, Greg KH wrote: > > On Tue, Oct 27, 2020 at 02:35:44PM +0100, Matteo Croce wrote: > > > From: Matteo Croce > > > > > > Limit the CPU number to num_possible_cpus(), because setting it > > > to a value lower than INT_MAX but higher than NR_CPUS produces the > > > following error on reboot and shutdown: > > > > > > Fixes: 1b3a5d02ee07 ("reboot: move arch/x86 reboot= handling to generic kernel") > > > Signed-off-by: Matteo Croce > > Reviewed-by: Petr Mladek > > > > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > > > > > The best way is to add the following line before Signed-off-by line: > > Cc: stable@vger.kernel.org > I see, sorry for the noise. Should I resend, or I eventually write to stable@vger.kernel.org after the merge? -- per aspera ad upstream