From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"thierry.reding" <thierry.reding@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers
Date: Tue, 25 Apr 2017 23:20:08 +0530 [thread overview]
Message-ID: <CAFp+6iE0=h-jqcuBSBawwB7cGccUaaYySiXS_xQjUwQvdf_1wQ@mail.gmail.com> (raw)
In-Reply-To: <ff663727-dcdf-b3e7-616d-5e770d32d782@nvidia.com>
On Tue, Apr 25, 2017 at 4:41 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 25/04/17 12:06, Vivek Gautam wrote:
>> On 04/25/2017 04:24 PM, Jon Hunter wrote:
>>> On 25/04/17 11:33, Philipp Zabel wrote:
>>>> On Tue, 2017-04-25 at 11:05 +0100, Jon Hunter wrote:
>>>>> On 25/04/17 05:15, Vivek Gautam wrote:
>>>>>> On 04/24/2017 06:15 PM, Jon Hunter wrote:
>>>>>>> On 18/04/17 12:21, Vivek Gautam wrote:
>>>>>>>> Make use of reset_control_array_*() set of APIs to manage
>>>>>>>> an array of reset controllers available with the device.
>>>>>>> Before we apply this patch, I need to check to see if the order of
>>>>>>> the
>>>>>>> resets managed by the PMC driver matter. Today the order of the
>>>>>>> resets
>>>>>>> is determined by the order they appear in the DT node and although
>>>>>>> the
>>>>>>> new APIs work in the same way they do not guarantee this. So let me
>>>>>>> check to see if we can any concerns about ordering here. Otherwise
>>>>>>> would
>>>>>>> be nice to use these APIs.
>>>>>> Right, that will be perfect.
>>>>> So I don't see any restrictions here and so I think this change is
>>>>> fine.
>>>> Thank you for checking.
>>>>
>>>>> BTW, for the DT case, is there any reason why we don't just say the
>>>>> order will be determine by the order the resets are list in the DT
>>>>> node?
>>>> I'd rather not make any promises, so I don't have to care about keeping
>>>> them. This makes it easier to think about and allows for more freedom in
>>>> changing the core code if needed.
>>>>
>>>> What if in the future there is a use case for enabling a bunch of resets
>>>> by flipping a number of bits in a single register at the same time? Or
>>>> if people accidentally depend on the ordering when in reality there is a
>>>> small delay necessary between assertions that just happens to be hidden
>>>> by the framework overhead?
>>>>
>>>> If there is a use case for an array of reset controls that must be
>>>> (de)asserted in a fixed order and doesn't need any delay between the
>>>> steps and is not suitable to be described by named resets for some
>>>> reason, we can discuss this. Until then, I'm happy that tegra pmc can
>>>> handle arrays without any particular ordering.
>>> OK, makes sense.
>>
>> Thanks Jon for testing this.
>
> Not tested yet :-)
>
> However, I will test this just to confirm. Are you planning on sending
> out a v4 soon?
Yes, I will send a v4 soon this week.
Thanks
Vivek
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-04-25 17:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 11:21 [PATCH V3 0/4] reset: APIs to manage a list of resets Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 1/4] reset: Add API to count number of reset available with device Vivek Gautam
2017-04-19 10:25 ` Philipp Zabel
2017-04-19 11:49 ` Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 2/4] reset: Add APIs to manage array of resets Vivek Gautam
2017-04-19 10:31 ` Philipp Zabel
2017-04-19 11:55 ` Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 3/4] usb: dwc3: of-simple: Add support to get resets for the device Vivek Gautam
2017-04-19 10:32 ` Philipp Zabel
2017-04-19 12:02 ` Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Vivek Gautam
2017-04-19 10:40 ` Philipp Zabel
2017-04-24 12:45 ` Jon Hunter
2017-04-25 4:15 ` Vivek Gautam
2017-04-25 10:05 ` Jon Hunter
2017-04-25 10:33 ` Philipp Zabel
2017-04-25 10:54 ` Jon Hunter
2017-04-25 11:06 ` Vivek Gautam
2017-04-25 11:11 ` Jon Hunter
2017-04-25 17:50 ` Vivek Gautam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFp+6iE0=h-jqcuBSBawwB7cGccUaaYySiXS_xQjUwQvdf_1wQ@mail.gmail.com' \
--to=vivek.gautam@codeaurora.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).