From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbdBHMKD (ORCPT ); Wed, 8 Feb 2017 07:10:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45348 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbdBHMJ7 (ORCPT ); Wed, 8 Feb 2017 07:09:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D799960A80 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <1486372421-29073-7-git-send-email-peter.chen@nxp.com> References: <1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com> From: Vivek Gautam Date: Wed, 8 Feb 2017 17:27:31 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration To: Peter Chen Cc: Greg KH , Alan Stern , Ulf Hansson , broonie@kernel.org, sre@kernel.org, "robh+dt" , shawnguo@kernel.org, rjw@rjwysocki.net, dbaryshkov@gmail.com, =?UTF-8?Q?Heiko_St=C3=BCbner?= , "linux-arm-kernel@lists.infradead.org" , p.zabel@pengutronix.de, "devicetree@vger.kernel.org" , Pawel Moll , Mark Rutland , Linux USB Mailing List , Arnd Bergmann , s.hauer@pengutronix.de, mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com, festevam@gmail.com, oscar@naiandei.net, Stephen Boyd , linux-pm@vger.kernel.org, stillcompiling@gmail.com, "linux-kernel@vger.kernel.org" , mka@chromium.org, vaibhav.hiremath@linaro.org, gary.bisson@boundarydevices.com, Hans Verkuil , krzk@kernel.org, Sriram Dash , Mathias Nyman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the system firmware or hardware. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Sriram Dash > Tested-by: Baolin Wang > Tested-by: Vivek Gautam > Tested-by: Alexander Sverdlin > Signed-off-by: Mathias Nyman > --- This patch doesn't work for me anymore on db820c target [1]. While the same kernel with reverts of patches [2] [3] and an older patch [4] by Grygorii Strashko works [5]. [1] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c-nonworking [2] 8c9f2de459c7 usb: dwc3: Do not set dma coherent mask [3] d64ff406e51e usb: dwc3: use bus->sysdev for DMA configuration [4] https://lkml.org/lkml/2016/4/25/813 [5] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c regards Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project