linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider
@ 2018-11-29 22:13 Evan Green
  2018-11-29 22:13 ` [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child Evan Green
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Evan Green @ 2018-11-29 22:13 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Rob Herring, Andy Gross
  Cc: Douglas Anderson, Stephen Boyd, Evan Green, devicetree,
	Rob Herring, linux-arm-msm, Can Guo, linux-kernel, Vivek Gautam,
	Manu Gautam, David Brown, Mark Rutland, linux-soc

This series fixes the QMP PHY bindings, which had specified #clock-cells
in the parent node, and had set it to 1. Putting it in the parent node is
wrong because the clock providers are the child nodes, so this change
moves it there. Having it set to 1 is also wrong, since nothing is ever
specified as to what should go in that cell. So this changes it to zero.
Finally, this change completes a little bit of code to actually allow these
exposed clocks to be pointed at in DT.

I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in
that it doesn't specify #clock-cells at all, has no child nodes, and
specifies clock-output-names in the parent node. As far as I can tell this
doesn't work at all. But I can't add the child nodes myself because I don't know
1) how many there are, and 2) the registers in them. I also have no way to test it.

Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996.

This patch sits atop the UFS device nodes series [1].

[1] https://lore.kernel.org/lkml/20181026173544.136037-1-evgreen@chromium.org/



Evan Green (4):
  dt-bindings: phy-qcom-qmp: Move #clock-cells to child
  arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells
  arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells
  phy: qcom-qmp: Expose provided clocks to DT

 .../devicetree/bindings/phy/qcom-qmp-phy.txt  | 11 ++++-----
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |  6 +++--
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |  4 ++--
 drivers/phy/qualcomm/phy-qcom-qmp.c           | 23 ++++++++++++++++++-
 4 files changed, 33 insertions(+), 11 deletions(-)

-- 
2.18.1


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2018-12-07  8:34 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 22:13 [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider Evan Green
2018-11-29 22:13 ` [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child Evan Green
2018-12-03 22:37   ` Stephen Boyd
2018-11-29 22:13 ` [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells Evan Green
2018-12-03 22:37   ` Stephen Boyd
2018-12-07  8:32   ` Vivek Gautam
2018-11-29 22:13 ` [PATCH v1 3/4] arm64: dts: qcom: sdm845: " Evan Green
2018-12-03 22:37   ` Stephen Boyd
2018-11-29 22:13 ` [PATCH v1 4/4] phy: qcom-qmp: Expose provided clocks to DT Evan Green
2018-12-03 22:38   ` Stephen Boyd
2018-12-03 23:12     ` Evan Green
2018-12-07  8:34   ` Vivek Gautam
2018-12-04  8:12 ` [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider Kishon Vijay Abraham I
2018-12-04 12:37   ` Vivek Gautam
2018-12-07  4:43     ` Kishon Vijay Abraham I
2018-12-07  6:25       ` Vivek Gautam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).