From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757101AbcLTI2E (ORCPT ); Tue, 20 Dec 2016 03:28:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49308 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbcLTI2B (ORCPT ); Tue, 20 Dec 2016 03:28:01 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 2153B61514 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <1474470325-32139-1-git-send-email-weiyj.lk@gmail.com> References: <1474470325-32139-1-git-send-email-weiyj.lk@gmail.com> From: Vivek Gautam Date: Tue, 20 Dec 2016 13:57:58 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] phy: rockchip-typec: fix non static symbol warnings To: Wei Yongjun Cc: Kishon Vijay Abraham I , Heiko Stuebner , Wei Yongjun , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 8:35 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warnings: > > drivers/phy/phy-rockchip-typec.c:295:16: warning: > symbol 'usb3_pll_cfg' was not declared. Should it be static? > drivers/phy/phy-rockchip-typec.c:312:16: warning: > symbol 'dp_pll_cfg' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/phy/phy-rockchip-typec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c > index 7cfb0f8..555604c 100644 > --- a/drivers/phy/phy-rockchip-typec.c > +++ b/drivers/phy/phy-rockchip-typec.c > @@ -292,7 +292,7 @@ struct phy_reg { > u32 addr; > }; > > -struct phy_reg usb3_pll_cfg[] = { > +static struct phy_reg usb3_pll_cfg[] = { const as well ? > { 0xf0, CMN_PLL0_VCOCAL_INIT }, > { 0x18, CMN_PLL0_VCOCAL_ITER }, > { 0xd0, CMN_PLL0_INTDIV }, > @@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = { > { 0x8, CMN_DIAG_PLL0_LF_PROG }, > }; > > -struct phy_reg dp_pll_cfg[] = { > +static struct phy_reg dp_pll_cfg[] = { const ? [..] Thanks Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project