From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbdCPDsp (ORCPT ); Wed, 15 Mar 2017 23:48:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49796 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdCPDso (ORCPT ); Wed, 15 Mar 2017 23:48:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F48D60DA5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <1489574410.2528.8.camel@pengutronix.de> References: <1487741048-24659-1-git-send-email-vivek.gautam@codeaurora.org> <1489574410.2528.8.camel@pengutronix.de> From: Vivek Gautam Date: Thu, 16 Mar 2017 09:18:40 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] reset: Add API to count number of reset available with device To: Philipp Zabel Cc: Felipe Balbi , Greg KH , Linux USB Mailing List , "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On Wed, Mar 15, 2017 at 4:10 PM, Philipp Zabel wrote: > Hi Vivek, > > On Fri, 2017-03-10 at 20:10 +0530, Vivek Gautam wrote: >> Hi Philipp, >> >> >> On Wed, Feb 22, 2017 at 10:54 AM, Vivek Gautam >> wrote: >> > Count number of reset phandles available with the device node >> > to know the resets a given device has. >> > >> > Cc: Philipp Zabel >> > Signed-off-by: Vivek Gautam >> > --- >> >> Any thoughts on this change? >> A small addition that seems useful. > > Sorry I missed this one earlier. > >> > >> > Based on torvald's master branch. >> > >> > include/linux/reset.h | 16 ++++++++++++++++ >> > 1 file changed, 16 insertions(+) >> > >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 5daff15722d3..88f63a640153 100644 >> > --- a/include/linux/reset.h >> > +++ b/include/linux/reset.h >> > @@ -2,6 +2,7 @@ >> > #define _LINUX_RESET_H_ >> > >> > #include >> > +#include >> > >> > struct reset_control; >> > >> > @@ -234,6 +235,21 @@ static inline struct reset_control *of_reset_control_get_shared_by_index( >> > } >> > >> > /** >> > + * of_reset_control_get_count - Count number of resets available with a device >> > + * @node: device to be reset by the controller >> > + */ >> > +static inline unsigned int of_reset_control_get_count(struct device_node *node) >> > +{ >> > + int count; >> > + >> > + count = of_count_phandle_with_args(node, "resets", "#reset-cells"); >> > + if (count < 0) >> > + return 0; > > Please don't silently ignore errors. gpiod_count doesn't ignore errors > either. tegra_powergate_of_resets in drivers/soc/tegra/pmc.c open codes > this, too. This should be changed so it can be used there, too. Sure, will change this. I can prepare a patch for tegra/pmc.c as well using this. Best regards Vivek > > regards > Philipp > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project